Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !935

You need to sign in or sign up before continuing.
Merged
Created Mar 10, 2021 by Xavier Thompson@xavier_thompsonOwner

software/theia: Adjust to Caddy build changes

  • Overview 14
  • Commits 1
  • Changes 1

The changes to the caddy build method in 1cfb657f break software/theia because software/theia installs the go language server gopls (see 5a7fffa5) and at some point this required extending the previous caddy build method to make go installs both caddy and gopls (see f56c476a).

See this test result showing the problem

Fix software/theia by removing the now obsolete extension of the caddy build method and dropping gopls (which wasn't quite working anyway) in the same move.

EDIT: instead of dropping gopls, upgrade to gopls@v0.6.6 which can be installed using the standard go install method.

Edited Mar 15, 2021 by Xavier Thompson
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix_theia_caddy_gopls
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7