Commit 03430f34 authored by Jérome Perrin's avatar Jérome Perrin

Don't do too much in Base_callDialogMethod when using "update" button: don't...

Don't do too much in Base_callDialogMethod when using "update" button: don't switch to deferred more in update, and don't change the skin manually when the URL is too big to redirect.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@36033 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 61984072
...@@ -236,8 +236,8 @@ for k, v in kw.items() :\n ...@@ -236,8 +236,8 @@ for k, v in kw.items() :\n
if v not in (None, [], ()) :\n if v not in (None, [], ()) :\n
clean_kw[k] = kw[k]\n clean_kw[k] = kw[k]\n
\n \n
# Handle deferred style\n # Handle deferred style, unless we are executing the update action\n
if clean_kw.get(\'deferred_style\', 0):\n if dialog_method != update_method and clean_kw.get(\'deferred_style\', 0):\n
clean_kw[\'deferred_portal_skin\'] = clean_kw.get(\'portal_skin\', None)\n clean_kw[\'deferred_portal_skin\'] = clean_kw.get(\'portal_skin\', None)\n
# XXX Hardcoded Deferred style name\n # XXX Hardcoded Deferred style name\n
clean_kw[\'portal_skin\'] = \'Deferred\'\n clean_kw[\'portal_skin\'] = \'Deferred\'\n
...@@ -259,7 +259,8 @@ url_params_string = make_query(clean_kw)\n ...@@ -259,7 +259,8 @@ url_params_string = make_query(clean_kw)\n
# If url is too long, we do not redirect to avoid crash.\n # If url is too long, we do not redirect to avoid crash.\n
# XXX: 2000 is an arbitrary value resulted from trial and error.\n # XXX: 2000 is an arbitrary value resulted from trial and error.\n
if (not(can_redirect) or len(url_params_string) > 2000):\n if (not(can_redirect) or len(url_params_string) > 2000):\n
if \'portal_skin\' in clean_kw:\n # change the skin, unless we are executing the update action\n
if dialog_method != update_method and \'portal_skin\' in clean_kw:\n
new_skin_name = clean_kw[\'portal_skin\']\n new_skin_name = clean_kw[\'portal_skin\']\n
context.getPortalObject().portal_skins.changeSkin(new_skin_name)\n context.getPortalObject().portal_skins.changeSkin(new_skin_name)\n
request.set(\'portal_skin\', new_skin_name)\n request.set(\'portal_skin\', new_skin_name)\n
...@@ -308,7 +309,7 @@ return request.RESPONSE.redirect(redirect_url)\n ...@@ -308,7 +309,7 @@ return request.RESPONSE.redirect(redirect_url)\n
</item> </item>
<item> <item>
<key> <string>_params</string> </key> <key> <string>_params</string> </key>
<value> <string>dialog_method, dialog_id, dialog_category=\'\', **kw</string> </value> <value> <string>dialog_method, dialog_id, dialog_category=\'\', update_method=None, **kw</string> </value>
</item> </item>
<item> <item>
<key> <string>errors</string> </key> <key> <string>errors</string> </key>
...@@ -328,7 +329,7 @@ return request.RESPONSE.redirect(redirect_url)\n ...@@ -328,7 +329,7 @@ return request.RESPONSE.redirect(redirect_url)\n
<dictionary> <dictionary>
<item> <item>
<key> <string>co_argcount</string> </key> <key> <string>co_argcount</string> </key>
<value> <int>3</int> </value> <value> <int>4</int> </value>
</item> </item>
<item> <item>
<key> <string>co_varnames</string> </key> <key> <string>co_varnames</string> </key>
...@@ -337,6 +338,7 @@ return request.RESPONSE.redirect(redirect_url)\n ...@@ -337,6 +338,7 @@ return request.RESPONSE.redirect(redirect_url)\n
<string>dialog_method</string> <string>dialog_method</string>
<string>dialog_id</string> <string>dialog_id</string>
<string>dialog_category</string> <string>dialog_category</string>
<string>update_method</string>
<string>kw</string> <string>kw</string>
<string>Products.ERP5Type.Log</string> <string>Products.ERP5Type.Log</string>
<string>log</string> <string>log</string>
...@@ -406,6 +408,7 @@ return request.RESPONSE.redirect(redirect_url)\n ...@@ -406,6 +408,7 @@ return request.RESPONSE.redirect(redirect_url)\n
<value> <value>
<tuple> <tuple>
<string></string> <string></string>
<none/>
</tuple> </tuple>
</value> </value>
</item> </item>
......
1599 1600
\ No newline at end of file \ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment