Commit f50f5463 authored by Romain Courteaud's avatar Romain Courteaud

erp5_core: jslint on gadget editor

parent 9f1b0df3
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
function readBlobAsDataURL(blob) { function readBlobAsDataURL(blob) {
var fr = new FileReader(); var fr = new FileReader();
return new RSVP.Promise(function (resolve, reject, notify) { return new RSVP.Promise(function (resolve, reject) {
fr.addEventListener("load", resolve); fr.addEventListener("load", resolve);
fr.addEventListener("error", reject); fr.addEventListener("error", reject);
fr.readAsDataURL(blob); fr.readAsDataURL(blob);
...@@ -70,20 +70,19 @@ ...@@ -70,20 +70,19 @@
.onStateChange(function (modification_dict) { .onStateChange(function (modification_dict) {
var element = this.element, var element = this.element,
gadget = this, gadget = this,
url,
div = document.createElement('div'), div = document.createElement('div'),
div_max = document.createElement('div'), div_max = document.createElement('div'),
queue = new RSVP.Queue(); queue = new RSVP.Queue();
if ((modification_dict.hasOwnProperty('editable')) || if ((modification_dict.hasOwnProperty('editable')) ||
(modification_dict.hasOwnProperty('editor')) || (modification_dict.hasOwnProperty('editor')) ||
(gadget.state.editor === 'notebook_editor')) { (gadget.state.editor === 'notebook_editor')) {
// Clear first to DOM, append after to reduce flickering/manip // Clear first to DOM, append after to reduce flickering/manip
while (element.firstChild) { while (element.firstChild) {
element.removeChild(element.firstChild); element.removeChild(element.firstChild);
} }
if (modification_dict.hasOwnProperty('maximize') || if (modification_dict.hasOwnProperty('maximize') ||
(gadget.state.editor === 'notebook_editor')) { (gadget.state.editor === 'notebook_editor')) {
// for fck_editor fields, we want to be able to maximize also in non editable // for fck_editor fields, we want to be able to maximize also in non editable
if ((gadget.state.maximize && gadget.state.editable) || if ((gadget.state.maximize && gadget.state.editable) ||
(gadget.state.maximize && gadget.state.editor === 'jsmd_editor') || (gadget.state.maximize && gadget.state.editor === 'jsmd_editor') ||
...@@ -118,14 +117,14 @@ ...@@ -118,14 +117,14 @@
(gadget.state.editor === 'pdf')) { (gadget.state.editor === 'pdf')) {
queue queue
.push(function () { .push(function () {
var url = editor_dict[gadget.state.editor].url; var gadget_url = editor_dict[gadget.state.editor].url;
if (gadget.state.editor === 'jsmd_editor' && if (gadget.state.editor === 'jsmd_editor' &&
!gadget.state.run && !gadget.state.run &&
gadget.state.editable) { gadget.state.editable) {
url = editor_dict.codemirror.url; gadget_url = editor_dict.codemirror.url;
} }
return gadget.declareGadget( return gadget.declareGadget(
url, gadget_url,
{ {
scope: 'editor', scope: 'editor',
sandbox: 'iframe', sandbox: 'iframe',
...@@ -207,7 +206,8 @@ ...@@ -207,7 +206,8 @@
return result; return result;
}); });
*/ */
} else if (this.state.editable && }
if (this.state.editable &&
(this.state.editor === 'text_area')) { (this.state.editor === 'text_area')) {
result = {}; result = {};
result[this.state.key] = this.element.querySelector('textarea').value; result[this.state.key] = this.element.querySelector('textarea').value;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment