The add-hoc assertin filter:

--

from typing import List

import lib2to3

from lib2to3.fixer_base import BaseFix
from lib2to3.fixer_util import Comma, Name

class FixAssertIn(BaseFix):

  PATTERN = """
      power< any+ trailer< '.' meth=("assertTrue" | "assertFalse")>
      trailer< '('
        comparison< (needle=any ( comp_op<'not' 'in'> | 'in' ) haystack=any) >
      ')' > >
  """

  def transform(self, node: lib2to3.pytree.Node,
                results: List[lib2to3.pytree.Base]):

    needle = results['needle']
    haystack = results['haystack']
    meth = results["meth"][0]

    method_map = {True: 'assertIn', False: 'assertNotIn'}
    method_in = meth.value == 'assertTrue'
    if 'not' in str(needle.parent.children[1]):
      method_in = not method_in
    meth.replace(Name(method_map[method_in], prefix=meth.prefix))

    needle.parent.children = [needle, Comma(), haystack]

so that we can run 2to3.fix_assert

this code was latin 1, causing issues for refactoring scripts

This updates the change to 32cead86 (xhtml_style: set a bottom
margin for dialog action, 2019-05-31) that got impacted by a rule
added on html and body in 5dde17a5 (xhtml_style: make editors in
bottom group use full height, 2022-08-22)

See merge request nexedi/erp5!1706

See also slapos.libnetworkcache@319b8b18

See merge request nexedi/erp5!1705

Make sure we don't set grouping reference on lines that have a valid
group only for source (or destination) but not for the other side.

gadget_html_viewer had styles to add a border for tables, so that they
look similar to tables added in CKEditor. One problem is that all tables
had borders, because HTML emails are often using tables to position the
content, when viewing an Mail Message from ERP5 back office interface
we could see all the borders, which looked a bit ugly.

These changes bring back a behavior closer to default style sheet of
browsers: tables have no border by default, but a rule is added to
emulate the rendering of border="1" attributes, so that tables edited
with CKEditor have borders and look the same in the editor or in the
html viewer.

See merge request nexedi/erp5!1704

Instead of add-hoc ", ".join

This reorganises a bit the tests to include the proxify feature of
ERP5 Form in ERP5 Form test

helpful to get an overview

Remove title, we don't need title and reference, because title is
acquired from reference, so they have the same value.

Add Causality, it can be useful for example to search in the module.

Add "more columns" for all properties from the view of a stripe session

This is now detected by coding style test

```py
kw = {...}
kw['metadata[key]'] = 'value'
connector.createSession(**kw)
```

but it would be more beautiful to be able to write it like this:

```py
kw = {...}
kw['metadata] = {'key': 'value'}
connector.createSession(**kw)
```

This would need change in the way the request data is serialised in
createSession.

This fixes things like:
  portal_catalog(source_reference={'query':'foo OR bar', 'key':'KeywordKey'})
or:
  portal_catalog(query=AutoQuery(source_reference='foo OR bar', key='KeywordKey'))

So we get:
  (`...`.`reference` LIKE '%foo%' OR `...`.`reference` LIKE '%bar%')

instead of:
  `...`.`reference` IN ('{\'query\': \'foo\', \'key\': \'KeywordKey\'}',
                        '{\'query\': \'bar\', \'key\': \'KeywordKey\'}')

Also, remove default values as it makes it easy for caller to leave arguments
out by mistake.
Also, use positional arguments as they are faster than named arguments.

See merge request nexedi/erp5!1698

this makes it easier to select the value by copy and paste.
Without the space, when double clicking on "value" in "key:value",
all "key:value" gets selected, with the space, only "value" gets
selected.

Invoking Zuite_waitForActivities when portal_activities is already
subscribed and while another thread from this process is already
executing activities causes infinite "Got a lock error, retrying...".

This situation happens when developer makes a mistake (runs the
tests without unsubscribing activities), so be nice to the developer
so that they don't have to restart Zope.

It's enough to set on the class and if we don't have it on instances, it
saves a few bytes in pickles

There have been a regression recently

Depends on nexedi/slapos!1290

See merge request nexedi/erp5!1695

When installing scripts or components from a business template, set
the _erp5_coverage_filename property so that the plugin is able to find
the corresponding code from the business template filesystem
representation.

coverage might use these to compute the upload URL for coverage data

coverage needs to be started before importing the modules, so it can
not be started so late in runUnitTest, it has to be started before
importing any Products/ERP5* code, ie. in slapos wrapper script.

See https://coverage.readthedocs.io/en/6.5.0/faq.html#q-why-do-the-bodies-of-functions-show-as-executed-but-the-def-lines-do-not
for more details about the rationale

Use super to always call the overridden method.

Extend the API to pass the business template being installed.

Call the hooks also when installing sub objects, they were not called
in one place.

Introduce an action script which redirects to the alarm, so that
"something happen" and user can see that the method was invoked. This
also makes it possible to use this action in selenium tests