1. 26 Mar, 2021 8 commits
    • Arnaud Fontaine's avatar
      RFC: Configurator Workflow. · d8eb1cd3
      Arnaud Fontaine authored
      * Rename WorkflowConfigurator PropertySheet to ConfiguratorWorkflow.
      * Add ConfiguratorWorkflowTransition PropertySheet for transition_form_id.
        => Should it be moved to standard 'action' instead?
      * Avoid defining Configurator-specific API in Workflow API, such as
        initializeDocument(). TODO: What about:
        - state.getAvailableTransitionList()
        - state.executeTransition()
        - state.getWorkflowHistory()
        - state.undoTransition()
        => erp5_configurator_standard:testStandardConfigurationWorkflow
      d8eb1cd3
    • Arnaud Fontaine's avatar
      RFC: ERP5Workflow: Existing Workflow PythonScript should not require any change. · 6bd8da36
      Arnaud Fontaine authored
      * Add WORKFLOW.{scripts,transitions...} property which is just a ComputedAttribute
        returning a dict (TODO: Instead of a dict, this should be ContainerTab to have
        objectIds()...).
      
      * Allow a Workflow Script to call another one by overriding portal_workflow.__getattr__.
        With DCWorkflow, `container` was bound to its parent (WORKFLOW.scripts which is a
        mapping), but now `container` is bound to the WORKFLOW itself as Transitions, Scripts
        and Variables are all at the same level. This is not very efficient but this is only
        in DCWorkflow compatibility mode after all.
      
        The initial implementation was creating a `ScriptContext`, a temporary object with
        all scripts of the current Workflow added. However, this required changing existing
        Workflow Script code and especially this did not work with the following use case:
        1. Script Context is created before calling a Workflow Script.
        2. That script calls a Workflow Script from another Workflow.
           => This will fail as ScriptContext is only created for the Workflow.
      
      This commit is going to be squashed before merging to master.
      6bd8da36
    • Arnaud Fontaine's avatar
      RFC: Merge erp5_workflow into erp5_core. · 8a9b3fe3
      Arnaud Fontaine authored
      Ignore for now the differences between ERP5Workflow implemented for Configurator
      a long time ago and "new" ERP5 Workflows.
      
      This commit is going to be squashed before merging to master.
      8a9b3fe3
    • Arnaud Fontaine's avatar
      RFC: ERP5Workflow: DC Workflows are now ERP5 objects. · 5dddac55
      Arnaud Fontaine authored
      Work done by Wenjie Zheng, Isabelle Vallet, Sebastien Robin and myself.
      5dddac55
    • Georgios Dagkakis's avatar
      erp5_core: Fixes in Folder delete · 746dce16
      Georgios Dagkakis authored
      See merge request nexedi/erp5!1381
      746dce16
    • Georgios Dagkakis's avatar
      erp5_core: Block Folder_delete for too large selections (>1000 documents) · 17cb437c
      Georgios Dagkakis authored
      as an extra safety measure
      17cb437c
    • Georgios Dagkakis's avatar
      erp5_core: Fixups in parts where we call manage_delObjects of Folder_delete · 7ea769a4
      Georgios Dagkakis authored
      and also addition of comments
      7ea769a4
    • Georgios Dagkakis's avatar
      erp5_core: Do not pass in whatever Exception in Folder_delete · 22bdcd89
      Georgios Dagkakis authored
      instead, check for the specifically expected Exception
      and in that case return with a warning
      
      Commit updates also testDelete of listbox_zuite accordingly
      22bdcd89
  2. 25 Mar, 2021 2 commits
  3. 24 Mar, 2021 2 commits
  4. 18 Mar, 2021 1 commit
  5. 15 Mar, 2021 2 commits
  6. 12 Mar, 2021 2 commits
  7. 11 Mar, 2021 2 commits
    • Jérome Perrin's avatar
      configurator_standard: repair accounting generation with default accounts · 42c2a915
      Jérome Perrin authored
      in 772d8fed (configurator_standard: use specific sale and purchase
      business processes, 2020-07-16) we introduced scripts to look up
      dynamically accounts to use for expense/income and VAT accounts, from
      supply lines, but this accidentally broke the case where no account can be
      found on supply lines: in this case, the accounting line was not generated.
      
      Ideally, there should be fallback accounts, to keep the same behavior and
      also to prevent generation of incomplete transactions.
      
      Review the scripts, so that the "Dynamic" scripts fallback on the account
      defined on the trade model path if not found and introduce new scripts,
      where the account is not taken dynamically, but only from the trade model
      path, for use on the payable/receivable lines (where we don't want to
      lookup the account dynamically, otherwise we'll use same account as for
      expense/income)
      42c2a915
    • Jérome Perrin's avatar
      accounting: fix grouping option of GL when running in deferred mode · 7058ab6f
      Jérome Perrin authored
      This omit_grouping_reference key was not set as selection parameters, so
      Node_getAccountingTransactionList could not find it in selection when running
      in deferred mode.
      
      In non deferred mode, it was working, because selection is set with values from
      request and it was same request, but deferred style uses activities, so it's
      different requests.
      7058ab6f
  8. 10 Mar, 2021 2 commits
    • Jérome Perrin's avatar
      base: make BankAccount.getReference use BankAccount.getIban · b808a05f
      Jérome Perrin authored
      When IBAN is defined, use it by default for reference. IBAN is used by
      default all over europe, so when it's set it should be used by default for
      reference.
      Mixing IBAN and other properties does not make sense, so this change
      should not have unexpected side effects.
      
      We also update "edit_order" on BankAccount_view so that title properly
      fallbacks on reference when reference is iban.
      b808a05f
    • Jérome Perrin's avatar
      Use payment conditions in "create related payment" action · 92dae2cf
      Jérome Perrin authored
      To ease "manual" (ie. not from payment rule simulation) creation of payments,
      update "create relate payment" so that it suggests the payment mode and the
      payment date from payment conditions of the invoice's trade condition.
      
      See merge request nexedi/erp5!1369
      92dae2cf
  9. 04 Mar, 2021 9 commits
  10. 03 Mar, 2021 6 commits
  11. 02 Mar, 2021 2 commits
  12. 01 Mar, 2021 2 commits