Use proper function name to make it possible to reuse in other "higher" layers...

Use proper function name to make it possible to reuse in other "higher" layers which use gadget system.
Use directly MochiKit name space.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@38470 20353a03-c40f-0410-a6d1-a30d3c3de9de

bt5/erp5_knowledge_pad/SkinTemplateItem/portal_skins/erp5_knowledge_pad/Base_viewKnowledgePadMacroLibrary.xml

@@ -109,7 +109,7 @@
       <span i18n:translate="" i18n:domain="ui">Tab name</span>: \n
       <input type="text" value="" name="pad_title" id="new_pad_title"/><br/><br/>\n
       <button type="button"\n
-              onclick="toggleElement(\'add_new_tab_dialog\');"\n
+              onclick="toggleElementById(\'add_new_tab_dialog\');"\n
               i18n:translate="" \n
               i18n:domain="ui">Cancel</button>\n
       <button type="button"\n
@@ -151,7 +151,7 @@
         <button type="button"\n
                 i18n:translate="" \n
                 i18n:domain="ui"\n
-                onclick="toggleElement(\'rename_tab_dialog\');">Cancel</button>\n
+                onclick="toggleElementById(\'rename_tab_dialog\');">Cancel</button>\n
         <button type="button"\n
                 i18n:translate="" \n
                 i18n:domain="ui"\n
@@ -208,7 +208,7 @@
                               i18n:attributes="title"\n
                               i18n:domain="ui"\n
                               class="clickable_image rename_tab_dialog_image"\n
-                              onclick="toggleElement(\'rename_tab_dialog\');"></span>\n
+                              onclick="toggleElementById(\'rename_tab_dialog\');"></span>\n
 \n
                         <span title="Remove"\n
                               i18n:attributes="title"\n
@@ -246,7 +246,7 @@
                 </tal:block>\n
                 <li class="tab"\n
                     tal:condition="not: isKnowledgePadTemplateUsed"\n
-                    onclick="toggleElement(\'add_new_tab_dialog\');"\n
+                    onclick="toggleElementById(\'add_new_tab_dialog\');"\n
                     i18n:translate="" i18n:domain="ui"\n
                     id="add_new_tab_dialog_link">Add tab</li>\n
                 <li class="tab"\n

bt5/erp5_knowledge_pad/SkinTemplateItem/portal_skins/erp5_knowledge_pad/erp5_knowledge_box.js.xml

@@ -2,10 +2,7 @@
 <ZopeData>
   <record id="1" aka="AAAAAAAAAAE=">
     <pickle>
-      <tuple>
-        <global name="File" module="OFS.Image"/>
-        <tuple/>
-      </tuple>
+      <global name="File" module="OFS.Image"/>
     </pickle>
     <pickle>
       <dictionary>
@@ -15,7 +12,7 @@
         </item>
         <item>
             <key> <string>_EtagSupport__etag</string> </key>
-            <value> <string>ts77806058.72</string> </value>
+            <value> <string>ts84965558.43</string> </value>
         </item>
         <item>
             <key> <string>__name__</string> </key>
@@ -297,9 +294,9 @@ function renameKnowledgePadToServer(dialog_id, title_id, \n
   toggle(dialog_id);\n
 }\n
 \n
-function toggleElement(dom_id){\n
-  /* add gadget to knowledge pad */\n
-  toggle(dom_id);\n
+function toggleElementById(dom_id){\n
+  /* Toggle element by its Id. */\n
+  MochiKit.Visual.toggle(dom_id);\n
 }\n
 \n
 function initialize(){\n
@@ -401,7 +398,7 @@ MochiKit.DOM.addLoadEvent(initialize);\n
         </item>
         <item>
             <key> <string>size</string> </key>
-            <value> <int>14748</int> </value>
+            <value> <int>14766</int> </value>
         </item>
         <item>
             <key> <string>title</string> </key>

bt5/erp5_knowledge_pad/bt/revision

-541
\ No newline at end of file
+542
\ No newline at end of file