Commit 1371f591 authored by Grégory Wisniewski's avatar Grégory Wisniewski

Fill the TODO list about the protocol module.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1125 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent 9232ec0a
...@@ -63,6 +63,9 @@ RC - Review output of pylint (CODE) ...@@ -63,6 +63,9 @@ RC - Review output of pylint (CODE)
- Clarify big packet handling, is it needed to split them at connection - Clarify big packet handling, is it needed to split them at connection
level, application level, use the ask/send/answer scheme ? Currently it's level, application level, use the ask/send/answer scheme ? Currently it's
not consistent, essentially with ask/answer/send partition table. not consistent, essentially with ask/answer/send partition table.
- Split protocol.py in a 'protocol' module, gather packet related data
(encoder, decoder, definition), don't use magic code to defined packet
types, group, consider using one class per paquet, extract patterns.
Storage Storage
......
...@@ -1441,7 +1441,6 @@ def askNodeInformation(): ...@@ -1441,7 +1441,6 @@ def askNodeInformation():
return Packet(ASK_NODE_INFORMATION) return Packet(ASK_NODE_INFORMATION)
def answerNodeInformation(node_list): def answerNodeInformation(node_list):
# XXX: copy-paste from notifyNodeInformation
body = [pack('!L', len(node_list))] body = [pack('!L', len(node_list))]
for node_type, address, uuid, state in node_list: for node_type, address, uuid, state in node_list:
uuid = _encodeUUID(uuid) uuid = _encodeUUID(uuid)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment