Commit f20e2962 authored by Grégory Wisniewski's avatar Grégory Wisniewski

Remove some meaningless TODO/FIXME/XXX.

- An update means that the item must be already known
- The __call__ replacement for __str__ might be a false good idea
- Module neo.master.test.connector no more exists
- XXX in client/app.py is related to deleted code.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1446 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent 6a381190
...@@ -236,7 +236,6 @@ class Application(object): ...@@ -236,7 +236,6 @@ class Application(object):
"""The client node application.""" """The client node application."""
def __init__(self, master_nodes, name, connector=None, **kw): def __init__(self, master_nodes, name, connector=None, **kw):
# XXX: use a configuration entry
# Start polling thread # Start polling thread
self.em = EventManager() self.em = EventManager()
self.poll_thread = ThreadedPoll(self.em) self.poll_thread = ThreadedPoll(self.em)
......
...@@ -213,7 +213,6 @@ class NodeManager(object): ...@@ -213,7 +213,6 @@ class NodeManager(object):
def __update(self, index_dict, old_key, new_key, node): def __update(self, index_dict, old_key, new_key, node):
""" Update an index from old to new key """ """ Update an index from old to new key """
# FIXME: should the old_key always be indexed ?
if old_key is not None: if old_key is not None:
del index_dict[old_key] del index_dict[old_key]
if new_key is not None: if new_key is not None:
...@@ -231,7 +230,6 @@ class NodeManager(object): ...@@ -231,7 +230,6 @@ class NodeManager(object):
def __updateSet(self, set_dict, old_key, new_key, node): def __updateSet(self, set_dict, old_key, new_key, node):
""" Update a set index from old to new key """ """ Update a set index from old to new key """
# FIXME: should the old_key always be indexed ?
if old_key in set_dict and node in set_dict[old_key]: if old_key in set_dict and node in set_dict[old_key]:
set_dict[old_key].remove(node) set_dict[old_key].remove(node)
if new_key is not None: if new_key is not None:
......
...@@ -251,7 +251,6 @@ class Packet(object): ...@@ -251,7 +251,6 @@ class Packet(object):
def getType(self): def getType(self):
return self.__class__ return self.__class__
# TODO: replace this with __call__ that take the id as parameter
def __str__(self): def __str__(self):
content = self._body content = self._body
length = PACKET_HEADER_SIZE + len(content) length = PACKET_HEADER_SIZE + len(content)
......
...@@ -303,9 +303,6 @@ class NeoTestBase(unittest.TestCase): ...@@ -303,9 +303,6 @@ class NeoTestBase(unittest.TestCase):
def checkAnswerObjectPresent(self, conn, **kw): def checkAnswerObjectPresent(self, conn, **kw):
return self.checkAnswerPacket(conn, Packets.AnswerObjectPresent, **kw) return self.checkAnswerPacket(conn, Packets.AnswerObjectPresent, **kw)
# XXX: imported from neo.master.test.connector since it's used at many places
connector_cpt = 0 connector_cpt = 0
class DoNothingConnector(Mock): class DoNothingConnector(Mock):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment