Commits · 6b121f40c3b7eba31e442a1137168d5e3c7154f6 · Stefane Fermigier / neo

03 Aug, 2009 20 commits

Reorder handler.py module, switch some methods to private level, group handlers · 6b121f40

Grégory Wisniewski authored Aug 03, 2009

to help navigation through the code.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1147 71dcc9de-d417-0410-9af5-da40c76e7ee4

6b121f40

Remove unused imports. · 10b108f7

Vincent Pelletier authored Aug 03, 2009

Make it simpler to call NEOCluster.__newProcess.
Categorise process by node type, and add accessors to retrieve all nodes of a given type.
Generate node uuids in the test and implement accessors for this.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1146 71dcc9de-d417-0410-9af5-da40c76e7ee4

10b108f7

Factorize error handlers with handleConnectionLost() · 5367588c
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1145 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5367588c

Remove commented-out lines. · 79c71851

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1144 71dcc9de-d417-0410-9af5-da40c76e7ee4

79c71851

Add a forgotten import of neo.util.bin . · 74da1f6c

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1143 71dcc9de-d417-0410-9af5-da40c76e7ee4

74da1f6c

Remove decorators used in shutdown handler, the handler implied those tests. · 13c848f9

Grégory Wisniewski authored Aug 03, 2009

Decorators defined in decorators.py are no more used in NEO, all extracted
patterns are now implied by the handlers.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1142 71dcc9de-d417-0410-9af5-da40c76e7ee4

13c848f9

Add the possibility to provide a UUID to a node upon startup. Mostly usefull... · 55ca6714

Vincent Pelletier authored Aug 03, 2009

Add the possibility to provide a UUID to a node upon startup. Mostly usefull in functional tests where we want to map a process to its UUID.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1141 71dcc9de-d417-0410-9af5-da40c76e7ee4

55ca6714

Remove unused definitions: · 631f2363

Grégory Wisniewski authored Aug 03, 2009

- SERIAL_NOT_FOUND is no more usefull.
- TIMEOUT_ERROR_CODE/handleTimeoutError is not used.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1140 71dcc9de-d417-0410-9af5-da40c76e7ee4

631f2363

Raise UnexpectedPacketError when receiving an error message, this is more · 6b79030c

Grégory Wisniewski authored Aug 03, 2009

consistent with other handler methods.
Remove the handleSerialNotFound method because it's never used.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1139 71dcc9de-d417-0410-9af5-da40c76e7ee4

6b79030c

Make getNewUUID a function so it can be reused without requiring to inherint from the whole class. · 6fb4c73e
Vincent Pelletier authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1138 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6fb4c73e
Move TODO items from README file and fix NEO Storage class name. · 5953febf
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1137 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5953febf

Remove duplicate check. · 1fb45279

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1136 71dcc9de-d417-0410-9af5-da40c76e7ee4

1fb45279

Make it possible to request current primary master from neoctl (neoctl command... · d0ba0475

Vincent Pelletier authored Aug 03, 2009

Make it possible to request current primary master from neoctl (neoctl command support & API entry, admin node support).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1135 71dcc9de-d417-0410-9af5-da40c76e7ee4

d0ba0475

Move a FIXME to the TODO list. · 3b9b7979

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1134 71dcc9de-d417-0410-9af5-da40c76e7ee4

3b9b7979

Factorise neoctl handler code. · ea3539cd

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1133 71dcc9de-d417-0410-9af5-da40c76e7ee4

ea3539cd

Some changes in the TODO list. · d76037c9

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1132 71dcc9de-d417-0410-9af5-da40c76e7ee4

d76037c9

When a node detect that it is sending a too big message, this is a bug, so raise · 526c8ce0

Grégory Wisniewski authored Aug 03, 2009

instead of notify the peer of the error. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1131 71dcc9de-d417-0410-9af5-da40c76e7ee4

526c8ce0

Remove expiration mechanism of temporarily down nodes because it's the admin · b32e01b3

Grégory Wisniewski authored Aug 03, 2009

node that switch them in down state and notify the administrators.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1130 71dcc9de-d417-0410-9af5-da40c76e7ee4

b32e01b3

Assert the packet size and remove the related XXX. · 6d9ff4c2

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1129 71dcc9de-d417-0410-9af5-da40c76e7ee4

6d9ff4c2

Clean imports and check node properties in (un)register(Server|UUID). · 45c34b7b
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1128 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
45c34b7b

31 Jul, 2009 11 commits

Move all common test functions into a single class, making it more reusable between tests. · bb0141e2
Vincent Pelletier authored Jul 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1127 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bb0141e2

Add a todo about reviewing hadnler split. · bacc91d9

Vincent Pelletier authored Jul 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1126 71dcc9de-d417-0410-9af5-da40c76e7ee4

bacc91d9

Fill the TODO list about the protocol module. · 1371f591

Grégory Wisniewski authored Jul 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1125 71dcc9de-d417-0410-9af5-da40c76e7ee4

1371f591

Client sleep a bit when no master are available, and a bit less when the master · 9232ec0a
Grégory Wisniewski authored Jul 31, 2009
```
found is not ready. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1124 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9232ec0a
Client reuse Dispatcher.unregister() for storage connections. · 193b7bd3
Grégory Wisniewski authored Jul 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1123 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
193b7bd3

Update TODO list and removed some inlined XXXs about: · f80e4cdd

Grégory Wisniewski authored Jul 31, 2009

- split big packets
- gather multiple objects in one sql requests
- sql injection
- no more use notification packet to change a node state
- reduce duplicates


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1122 71dcc9de-d417-0410-9af5-da40c76e7ee4

f80e4cdd

When the primary lost a secondary, it have to set it in down state and broadcast · 3e440366

Grégory Wisniewski authored Jul 31, 2009

the information to others.
Remove an XXX: As for client node, a master don't leep its UUID, so it have to
be dropped from nodes managers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1121 71dcc9de-d417-0410-9af5-da40c76e7ee4

3e440366

Allow create a new cluster with more than one storage node, this is controlled · 5912c7f7

Grégory Wisniewski authored Jul 31, 2009

by the REQUIRED_NODE_NUMBER definition, and keep the default with one node.
Add a XXX about broadcastNodeInformation possible improvement.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1120 71dcc9de-d417-0410-9af5-da40c76e7ee4

5912c7f7

Bug fix: ServerSocket was not set in non-blocking mode, causing the master wait · c31dc434

Grégory Wisniewski authored Jul 31, 2009

on the recv() until a ping was sent to it. Now the non-bloking state is defined
in the Connector __init__ to ensure all sockets will not block.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1118 71dcc9de-d417-0410-9af5-da40c76e7ee4

c31dc434

When the disconnection is not caused by a broken node event, pick the state... · 92f2ab72

Vincent Pelletier authored Jul 31, 2009

When the disconnection is not caused by a broken node event, pick the state from a mapping: by default, a disconnected node is considered down (ie, removed from node manager as soon as it gets disconnected), with the exception of a storage node (it must be kept in partition table, so it must also be kept in node manager).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1117 71dcc9de-d417-0410-9af5-da40c76e7ee4

92f2ab72

Do not silently ignore an unknown node in disconnection handler method. Any... · 7990c1dc

Vincent Pelletier authored Jul 31, 2009

Do not silently ignore an unknown node in disconnection handler method. Any node being disconnedted at the level of this handler must be known, otherwise it's a bug.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1116 71dcc9de-d417-0410-9af5-da40c76e7ee4

7990c1dc

30 Jul, 2009 9 commits

Add a task in the TODO list. · 3c0e72ff

Grégory Wisniewski authored Jul 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1115 71dcc9de-d417-0410-9af5-da40c76e7ee4

3c0e72ff

Since the startup/recovery cluster process is now manually handled, we don't · ce1574c1

Grégory Wisniewski authored Jul 30, 2009

care about greater IDs received in service state, we don't have to receive this
packet.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1114 71dcc9de-d417-0410-9af5-da40c76e7ee4

ce1574c1

Bug fix: Client now put fake packet in queue to release requesting thread, and · c9d2c07b

Grégory Wisniewski authored Jul 30, 2009

use Dispatcher.unregister() to avoid duplicates.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1113 71dcc9de-d417-0410-9af5-da40c76e7ee4

c9d2c07b

Make count_dict property always contain all nodes, even if they are registered... · 63f617bb

Vincent Pelletier authored Jul 30, 2009

Make count_dict property always contain all nodes, even if they are registered for the first time in FEEDING state.
This fixes the annoying KeyError raised in log method when it happens.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1112 71dcc9de-d417-0410-9af5-da40c76e7ee4

63f617bb

Uncomment required code to make RLock class be detected as reentrant. · cd29ad22
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1111 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cd29ad22

Improve lock tracing: · 8f2ba439

Vincent Pelletier authored Jul 30, 2009

- Don't complain about deadlocks when reentrant (they cannot happen on a single lock, and more complex deadlocks are just not reported here)
- Display a complete traceback when a deadlock is detected (just displaying the line acquiring the lock is sometimes not enough).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1110 71dcc9de-d417-0410-9af5-da40c76e7ee4

8f2ba439

Add an entry in the TODO list about send ask() packets from the client thread · bba0e284
Grégory Wisniewski authored Jul 30, 2009
```
poll.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1109 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bba0e284

Client don't have to register a storage if not found by server address. First · 99a52d3c

Grégory Wisniewski authored Jul 30, 2009

this must be already done, then if node object already exist, so create another
is wrong.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1108 71dcc9de-d417-0410-9af5-da40c76e7ee4

99a52d3c

Fix enableStorageList method that expect an uuid list instead of a node list. · 21fd729f

Grégory Wisniewski authored Jul 30, 2009

This fix the use of 'neoctl add all'.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1107 71dcc9de-d417-0410-9af5-da40c76e7ee4

21fd729f