Commit 0e613db7 authored by Grzegorz Bizon's avatar Grzegorz Bizon Committed by Robert Speicher

Add more validation tests for note model

parent 57b551a1
......@@ -12,6 +12,33 @@ describe Note, models: true do
describe 'validation' do
it { is_expected.to validate_presence_of(:note) }
it { is_expected.to validate_presence_of(:project) }
context 'when note is comment on commit' do
before { allow(subject).to receive(:for_commit?).and_return(true) }
it { is_expected.to validate_presence_of(:commit_id) }
it { is_expected.to_not validate_presence_of(:noteable_id) }
end
context 'when note is not comment on commit' do
before { allow(subject).to receive(:for_commit?).and_return(false) }
it { is_expected.to_not validate_presence_of(:commit_id) }
it { is_expected.to validate_presence_of(:noteable_id) }
end
context 'when noteable and note project is different' do
subject do
build(:note, noteable: create(:issue), project: create(:project))
end
it { is_expected.to be_invalid }
end
context 'when noteable and note project is the same one' do
subject { create(:note) }
it { is_expected.to be_valid }
end
end
describe "Commit notes" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment