Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
1a4b1e97
Commit
1a4b1e97
authored
Oct 05, 2016
by
Douglas Barbosa Alexandre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update Boards::Lists::MoveService to move lists inside a specific board
parent
af87cf7c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
5 deletions
+6
-5
app/services/boards/lists/move_service.rb
app/services/boards/lists/move_service.rb
+2
-1
spec/services/boards/lists/move_service_spec.rb
spec/services/boards/lists/move_service_spec.rb
+4
-4
No files found.
app/services/boards/lists/move_service.rb
View file @
1a4b1e97
...
...
@@ -2,6 +2,7 @@ module Boards
module
Lists
class
MoveService
<
Boards
::
BaseService
def
execute
(
list
)
@board
=
list
.
board
@old_position
=
list
.
position
@new_position
=
params
[
:position
]
...
...
@@ -16,7 +17,7 @@ module Boards
private
attr_reader
:old_position
,
:new_position
attr_reader
:
board
,
:
old_position
,
:new_position
def
valid_move?
new_position
.
present?
&&
new_position
!=
old_position
&&
...
...
spec/services/boards/lists/move_service_spec.rb
View file @
1a4b1e97
...
...
@@ -2,16 +2,16 @@ require 'spec_helper'
describe
Boards
::
Lists
::
MoveService
,
services:
true
do
describe
'#execute'
do
let
(
:project
)
{
create
(
:
project_with_board
)
}
let
(
:board
)
{
project
.
board
}
let
(
:project
)
{
create
(
:
empty_project
)
}
let
(
:board
)
{
create
(
:board
,
project:
project
)
}
let
(
:user
)
{
create
(
:user
)
}
let!
(
:backlog
)
{
project
.
board
.
backlog_list
}
let!
(
:backlog
)
{
create
(
:backlog_list
,
board:
board
)
}
let!
(
:planning
)
{
create
(
:list
,
board:
board
,
position:
0
)
}
let!
(
:development
)
{
create
(
:list
,
board:
board
,
position:
1
)
}
let!
(
:review
)
{
create
(
:list
,
board:
board
,
position:
2
)
}
let!
(
:staging
)
{
create
(
:list
,
board:
board
,
position:
3
)
}
let!
(
:done
)
{
project
.
board
.
done_list
}
let!
(
:done
)
{
create
(
:done_list
,
board:
board
)
}
context
'when list type is set to label'
do
it
'keeps position of lists when new position is nil'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment