updated relation_factory based on MR feedback

279412f9 · James Lopez · 77794579 · 279412f9
Commit 279412f9 authored Jun 14, 2016 by James Lopez
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

lib/gitlab/import_export/relation_factory.rb lib/gitlab/import_export/relation_factory.rb +3 -3

No files found.
--- a/lib/gitlab/import_export/relation_factory.rb
+++ b/lib/gitlab/import_export/relation_factory.rb
@@ -57,11 +57,11 @@ module Gitlab
        author = @relation_hash.delete('author')
-        update_note_for_missing_author(author['name']) if can_update_notes?
+        update_note_for_missing_author(author['name']) if missing_author?
      end
-      def can_update_notes?
+      def missing_author?
-        (admin_user? && @members_mapper.missing_author_ids.include?(old_author_id)) || !admin_user?
+        !admin_user? || @members_mapper.missing_author_ids.include?(old_author_id)
      end
      def missing_author_note(updated_at, author_name)