Commit 57dd206f authored by Robert Speicher's avatar Robert Speicher

Merge branch 'css-selector-format' into 'master'

Disabled SelectorFormat rule for SCSS Lint in order to get the Rake
task passing sooner.

SelectorFormat enforces that CSS classes and IDs use lowercase
hyphenated style, `like-this`, but a not-insignificant amount of
selectors in the codebase are `like_this`.

Fixing the selectors that break this rule would require changing HTML
as well, and potentially break JavaScript hooks, among other things. So
I decided to disable this rule for the time being, hopefully making it
easier to fix all the remaining warnings SCSS Lint is giving by removing
the most problematic rule.

Discussed in #14299.

See merge request !3309
parents 62ffdbeb 8d7ad535
...@@ -100,7 +100,7 @@ linters: ...@@ -100,7 +100,7 @@ linters:
# Selectors should always use hyphenated-lowercase, rather than camelCase or # Selectors should always use hyphenated-lowercase, rather than camelCase or
# snake_case. # snake_case.
SelectorFormat: SelectorFormat:
enabled: true enabled: false
convention: hyphenated_lowercase convention: hyphenated_lowercase
# Prefer the shortest shorthand form possible for properties that support it. # Prefer the shortest shorthand form possible for properties that support it.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment