Commit 682ec038 authored by Robert Speicher's avatar Robert Speicher

Rename `CommitRange#sha_from_as_param` to `#suffixed_sha_from`

parent 165cacce
...@@ -61,14 +61,14 @@ class CommitRange ...@@ -61,14 +61,14 @@ class CommitRange
# Returns a String for use in a link's title attribute # Returns a String for use in a link's title attribute
def reference_title def reference_title
"Commits #{sha_from_as_param} through #{sha_to}" "Commits #{suffixed_sha_from} through #{sha_to}"
end end
# Return a Hash of parameters for passing to a URL helper # Return a Hash of parameters for passing to a URL helper
# #
# See `namespace_project_compare_url` # See `namespace_project_compare_url`
def to_param def to_param
{ from: sha_from_as_param, to: sha_to } { from: suffixed_sha_from, to: sha_to }
end end
def exclude_start? def exclude_start?
...@@ -91,7 +91,7 @@ class CommitRange ...@@ -91,7 +91,7 @@ class CommitRange
end end
def commit_from def commit_from
@commit_from ||= project.repository.commit(sha_from_as_param) @commit_from ||= project.repository.commit(suffixed_sha_from)
end end
def commit_to def commit_to
...@@ -100,7 +100,7 @@ class CommitRange ...@@ -100,7 +100,7 @@ class CommitRange
private private
def sha_from_as_param def suffixed_sha_from
sha_from + (exclude_start? ? '^' : '') sha_from + (exclude_start? ? '^' : '')
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment