Fix unchanged structure. Add favicon for 'failed_allowed' and...

Fix unchanged structure. Add favicon for 'failed_allowed' and 'success_warning' because it'll be used.

lib/gitlab/ci/status/build/failed_allowed.rb

@@ -13,6 +13,10 @@ module Gitlab
             'icon_status_warning'
           end
 
+          def favicon
+            'favicon_status_warning'
+          end
+
           def group
             'failed_with_warnings'
           end

lib/gitlab/ci/status/success_warning.rb

@@ -20,6 +20,10 @@ module Gitlab
           'icon_status_warning'
         end
 
+        def favicon
+          'favicon_status_warning'
+        end
+
         def group
           'success_with_warnings'
         end

spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb

@@ -22,6 +22,12 @@ describe Gitlab::Ci::Status::Build::FailedAllowed do
     end
   end
 
+  describe '#favicon' do
+    it 'returns a warning favicon' do
+      expect(subject.favicon).to eq 'favicon_status_warning'
+    end
+  end
+
   describe '#label' do
     it 'returns information about failed but allowed to fail status' do
       expect(subject.label).to eq 'failed (allowed to fail)'

spec/lib/gitlab/ci/status/success_warning_spec.rb

@@ -17,6 +17,10 @@ describe Gitlab::Ci::Status::SuccessWarning do
     it { expect(subject.icon).to eq 'icon_status_warning' }
   end
 
+  describe '#favicon' do
+    it { expect(subject.favicon).to eq 'favicon_status_warning' }
+  end
+
   describe '#group' do
     it { expect(subject.group).to eq 'success_with_warnings' }
   end

spec/serializers/build_entity_spec.rb

@@ -29,8 +29,8 @@ describe BuildEntity do
   end
 
   it 'contains details' do
-    expect(subject).to include :details
-    expect(subject[:details][:status]).to include :icon, :favicon, :text, :label
+    expect(subject).to include :status
+    expect(subject[:status]).to include :icon, :favicon, :text, :label
   end
 
   context 'when build is a regular job' do