Commit 8db088cc authored by Connor Shea's avatar Connor Shea Committed by Sean McGivern

Don't use global variables.

parent 0baaf490
...@@ -2,10 +2,10 @@ ...@@ -2,10 +2,10 @@
(function() { (function() {
$(function() { $(function() {
url = $(".js-edit-blob-form").data("relative-url-root"); var url = $(".js-edit-blob-form").data("relative-url-root");
url += $(".js-edit-blob-form").data("assets-prefix"); url += $(".js-edit-blob-form").data("assets-prefix");
blob = new EditBlob(url, $('.js-edit-blob-form').data('blob-language')); var blob = new EditBlob(url, $('.js-edit-blob-form').data('blob-language'));
new NewCommitForm($('.js-edit-blob-form')); new NewCommitForm($('.js-edit-blob-form'));
}); });
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
(function() { (function() {
$(function() { $(function() {
editor = ace.edit("editor") var editor = ace.edit("editor")
$(".snippet-form-holder form").on('submit', function() { $(".snippet-form-holder form").on('submit', function() {
$(".snippet-file-content").val(editor.getValue()); $(".snippet-file-content").val(editor.getValue());
......
...@@ -44,7 +44,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps ...@@ -44,7 +44,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
end end
step 'I should see its content with new lines preserved at end of file' do step 'I should see its content with new lines preserved at end of file' do
expect(evaluate_script('blob.editor.getValue()')).to eq "Sample\n\n\n" expect(evaluate_script('ace.edit("editor").getValue()')).to eq "Sample\n\n\n"
end end
step 'I click link "Raw"' do step 'I click link "Raw"' do
...@@ -65,7 +65,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps ...@@ -65,7 +65,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
step 'I can edit code' do step 'I can edit code' do
set_new_content set_new_content
expect(evaluate_script('blob.editor.getValue()')).to eq new_gitignore_content expect(evaluate_script('ace.edit("editor").getValue()')).to eq new_gitignore_content
end end
step 'I edit code' do step 'I edit code' do
...@@ -74,7 +74,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps ...@@ -74,7 +74,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
end end
step 'I edit code with new lines at end of file' do step 'I edit code with new lines at end of file' do
execute_script('blob.editor.setValue("Sample\n\n\n")') execute_script('ace.edit("editor").setValue("Sample\n\n\n")')
end end
step 'I fill the new file name' do step 'I fill the new file name' do
...@@ -378,7 +378,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps ...@@ -378,7 +378,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
private private
def set_new_content def set_new_content
execute_script("blob.editor.setValue('#{new_gitignore_content}')") execute_script("ace.edit('editor').setValue('#{new_gitignore_content}')")
end end
# Content of the gitignore file on the seed repository. # Content of the gitignore file on the seed repository.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment