Fixed jump to discussion button not showing

a9349f57 · Phil Hughes · Fatih Acet · c8133c53 · a9349f57
Commit a9349f57 authored Nov 09, 2016 by Phil Hughes Committed by Fatih Acet Nov 10, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

app/assets/javascripts/diff_notes/diff_notes_bundle.js.es6 app/assets/javascripts/diff_notes/diff_notes_bundle.js.es6 +5 -1

No files found.
--- a/app/assets/javascripts/diff_notes/diff_notes_bundle.js.es6
+++ b/app/assets/javascripts/diff_notes/diff_notes_bundle.js.es6
@@ -8,11 +8,15 @@
 //= require_directory ./components

 $(() => {
+  const COMPONENT_SELECTOR = 'resolve-btn, resolve-discussion-btn, jump-to-discussion, comment-and-resolve-btn';
+
  window.gl = window.gl || {};
  window.gl.diffNoteApps = {};

  gl.diffNotesCompileComponents = () => {
-    const $components = $('resolve-btn, resolve-discussion-btn, jump-to-discussion, comment-and-resolve-btn');
+    const $components = $(COMPONENT_SELECTOR).filter(function () {
+      return $(this).closest('resolve-count').length !== 1;
+    });

    if ($components) {
      $components.each(function () {