Commit f81352f5 authored by Robert Schilling's avatar Robert Schilling

Fix minor styling issues from code review

parent 20d4ca4c
...@@ -40,8 +40,8 @@ Parameters: ...@@ -40,8 +40,8 @@ Parameters:
## Get a single repository tag ## Get a single repository tag
Get a specific repository tag determined by its name. It returns 200 together Get a specific repository tag determined by its name. It returns `200` together
with the tag information if the tag exists. It returns 404 if the tag does not with the tag information if the tag exists. It returns `404` if the tag does not
exist. exist.
``` ```
......
...@@ -19,15 +19,15 @@ module API ...@@ -19,15 +19,15 @@ module API
# Get a single repository tag # Get a single repository tag
# #
# Parameters: # Parameters:
# id (required) - The ID of a project # id (required) - The ID of a project
# tag_name (required) - The name of the tag # tag_name (required) - The name of the tag
# Example Request: # Example Request:
# GET /projects/:id/repository/tags/:tag_name # GET /projects/:id/repository/tags/:tag_name
get ":id/repository/tags/:tag_name", requirements: { tag_name: /.*/ } do get ":id/repository/tags/:tag_name", requirements: { tag_name: /.+/ } do
tag = user_project.repository.find_tag(params[:tag_name]) tag = user_project.repository.find_tag(params[:tag_name])
not_found!('Tag') unless tag not_found!('Tag') unless tag
present tag, with: Entities::RepoTag, project: user_project present tag, with: Entities::RepoTag, project: user_project
end end
# Create tag # Create tag
......
...@@ -40,17 +40,17 @@ describe API::API, api: true do ...@@ -40,17 +40,17 @@ describe API::API, api: true do
end end
end end
describe "GET /projects/:id/repository/tags/:tag_name" do describe 'GET /projects/:id/repository/tags/:tag_name' do
let(:tag_name) { project.repository.tag_names.sort.reverse.first } let(:tag_name) { project.repository.tag_names.sort.reverse.first }
it 'should return a specific tag' do it 'returns a specific tag' do
get api("/projects/#{project.id}/repository/tags/#{tag_name}", user) get api("/projects/#{project.id}/repository/tags/#{tag_name}", user)
expect(response.status).to eq(200) expect(response.status).to eq(200)
expect(json_response['name']).to eq(tag_name) expect(json_response['name']).to eq(tag_name)
end end
it 'should return 404 for an invalid tag name' do it 'returns 404 for an invalid tag name' do
get api("/projects/#{project.id}/repository/tags/foobar", user) get api("/projects/#{project.id}/repository/tags/foobar", user)
expect(response.status).to eq(404) expect(response.status).to eq(404)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment