Commit fee8dcde authored by Yorick Peterse's avatar Yorick Peterse

Merge branch 'todo-update-order' into 'master'

Remove unnecessary ORDER BY clause when updating todos

See merge request !10399
parents e7e93072 2332bf34
......@@ -204,7 +204,7 @@ class TodoService
# Only update those that are not really on that state
todos = todos.where.not(state: state)
todos_ids = todos.pluck(:id)
todos.update_all(state: state)
todos.unscope(:order).update_all(state: state)
current_user.update_todos_count_cache
todos_ids
end
......
---
title: Remove unnecessary ORDER BY clause when updating todos
merge_request:
author: mhasbini
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment