- 25 May, 2016 2 commits
-
-
Phil Hughes authored
Closes #17844
-
Jeroen van Baarsen authored
Changed the Slack build message to use the singular duration if necessary ## What does this MR do? Previously, the Slack build notification would say "second(s)" even when the duration was only 1 second. This MR fixes that. This is my first time writing Ruby code and my first MR on Gitlab, so feedback is very much appreciated! See merge request !4253
-
- 24 May, 2016 14 commits
-
-
Stan Hu authored
Update health_check.md - Fix spelling of admin/health_check path. [ci skip] ## What does this MR do? Fix the spelling of admin/heath_check to admin/health_check in health_check documentation ## Are there points in the code the reviewer needs to double check? No ## Why was this MR needed? Fix a spelling error that may mislead a user on the proper URL/Path to check the GitLab health. ## What are the relevant issue numbers? ## Screenshots (if relevant) See merge request !4282
-
Jacob Schatz authored
Updated snippets UI ![Screen_Shot_2016-05-18_at_14.11.54](/uploads/2544351e50f19a36c4ba9a7a92d5544b/Screen_Shot_2016-05-18_at_14.11.54.png) Closes #14328 See merge request !4194
-
Jacob Schatz authored
Project settings UI update ![Screen_Shot_2016-05-16_at_16.42.55](/uploads/2e308cbf26a002fc411c3e84b663a5d1/Screen_Shot_2016-05-16_at_16.42.55.png)![Screen_Shot_2016-05-16_at_16.43.01](/uploads/8d983c43307c65852efe002f6e9482d9/Screen_Shot_2016-05-16_at_16.43.01.png)![Screen_Shot_2016-05-16_at_16.43.16](/uploads/6124e0600cc0e5b309a60b065409d537/Screen_Shot_2016-05-16_at_16.43.16.png)![Screen_Shot_2016-05-16_at_16.43.13](/uploads/177976c2c08034e096e7ebdcad1f369f/Screen_Shot_2016-05-16_at_16.43.13.png) See merge request !4162
-
Ryan Rustong authored
-
Jacob Schatz authored
Clicking changes tab scrolls the window to show the content When you click on the changes tab in a merge request, it will now scroll the window down to the content. ![scroll](/uploads/c5db23e1c32b1fe62bf4efb815b3f055/scroll.gif) Closes #15133 See merge request !4192
-
Robert Speicher authored
Update branch name from 8-7-stable to 8-8-stable Fix inconsistency with the command listed above. [ci skip] See merge request !4274
-
Robert Speicher authored
Fix typo in link on monitoring help page Closes #17809 [ci skip] See merge request !4281
-
sebastian-schmid authored
-
Florian Preinstorfer authored
-
Aran Koning authored
-
Stan Hu authored
Add CHANGELOG entry about using gitlab-shell v3.0.0 See merge request !4272
-
Stan Hu authored
[ci skip]
-
Stan Hu authored
Use gitlab-shell 3.0.0 Update gitlab-shell to v3.0.0 as discussed in https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/59 See merge request !4246
-
Achilleas Pipinellis authored
Update Google integration API workflow ## What does this MR do? Updates the Google API workflow. ## Are there points in the code the reviewer needs to double check? No ## Why was this MR needed? Reported by a user https://gitlab.zendesk.com/agent/tickets/24402 ## Screenshots (if relevant) ![image](/uploads/6b1cf71ebc09589c05290575e0c8ea23/image.png) See merge request !4260
-
- 23 May, 2016 24 commits
-
-
Dmitriy Zaporozhets authored
Project navigation redesign Based on !3980. Part of #14838. This MR targets on desktop version. Mobile version improvements will be in separate merge request. Part of #17522 cc @jschatz1 See merge request !4053
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Add rubocop-rspec Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17761 See merge request !4264
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
-
Robert Speicher authored
Its time for 8.9 See merge request !4262
-
Robert Speicher authored
[ci skip]
-
Robert Speicher authored
Almost all cops are starting as disabled until we can fix their violations.
-
Robert Speicher authored
Enable multiple Rubocop cops that can be enabled See https://gitlab.com/gitlab-org/gitlab-ce/issues/17406 This enabled following cops: ```text Lint/CircularArgumentReference: Description: Default values in optional keyword arguments and optional ordinal arguments ---------------- Lint/ConditionPosition: Description: Checks for condition placed in a confusing position relative to the keyword. StyleGuide: https://github.com/bbatsov/ruby-style-guide#same-line-condition ---------------- Lint/Debugger: Description: Check for debugger calls. ---------------- Lint/DefEndAlignment: Description: Align ends corresponding to defs correctly. ---------------- Lint/DuplicateMethods: Description: Check for duplicate method definitions. ---------------- Lint/DuplicatedKey: Description: Check for duplicate keys in hash literals. ---------------- Lint/EachWithObjectArgument: Description: Check for immutable argument given to each_with_object. ---------------- Lint/ElseLayout: Description: Check for odd code arrangement in an else block. ---------------- Lint/EmptyEnsure: Description: Checks for empty ensure block. ---------------- Lint/EmptyInterpolation: Description: Checks for empty string interpolation. ---------------- Lint/EndAlignment: Description: Align ends correctly. ---------------- Lint/EndInMethod: Description: END blocks should not be placed inside method definitions. ---------------- Lint/EnsureReturn: Description: Do not use return in an ensure block. StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-return-ensure ---------------- Lint/Eval: Description: The use of eval represents a serious security risk. ---------------- Lint/FloatOutOfRange: Description: Catches floating-point literals too large or small for Ruby to represent. ---------------- Lint/FormatParameterMismatch: Description: The number of parameters to format/sprint must match the fields. ---------------- Lint/ImplicitStringConcatenation: Description: Checks for adjacent string literals on the same line, which could better be represented as a single string literal. ---------------- Lint/InvalidCharacterLiteral: Description: Checks for invalid character literals with a non-escaped whitespace character. ---------------- Lint/LiteralInInterpolation: Description: Checks for literals used in interpolation. ---------------- Lint/NestedMethodDefinition: Description: Do not use nested method definitions. StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-methods ---------------- Lint/NextWithoutAccumulator: Description: Do not omit the accumulator when calling `next` in a `reduce`/`inject` block. ---------------- Lint/RandOne: Description: Checks for `rand(1)` calls. Such calls always return `0` and most likely a mistake. ---------------- Lint/RequireParentheses: Description: Use parentheses in the method call to avoid confusion about precedence. ---------------- Lint/UnreachableCode: Description: Unreachable code. ---------------- Lint/UselessComparison: Description: Checks for comparison of something with itself. ---------------- Lint/UselessElseWithoutRescue: Description: Checks for useless `else` in `begin..end` without `rescue`. ---------------- Lint/UselessSetterCall: Description: Checks for useless setter call to a local variable. ---------------- Lint/Void: Description: Possible use of operator/literal/variable in void context. ---------------- Performance/DoubleStartEndWith: Description: Use `str.{start,end}_with?(x, ..., y, ...)` instead of `str.{start,end}_with?(x, ...) || str.{start,end}_with?(y, ...)`. ---------------- Performance/RedundantSortBy: Description: Use `sort` instead of `sort_by { |x| x }`. ---------------- Rails/FindBy: Description: Prefer find_by over where.first. Include: - app/models/**/*.rb ---------------- Rails/FindEach: Description: Prefer all.find_each over all.find. Include: - app/models/**/*.rb ---------------- Rails/PluralizationGrammar: Description: Checks for incorrect grammar when using methods like `3.day.ago`. ---------------- Rails/ScopeArgs: Description: Checks the arguments of ActiveRecord scopes. Include: - app/models/**/*.rb ``` See merge request !4261
-
Robert Speicher authored
Enable Style/SpaceAroundKeyword cop and fix offenses Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478 See merge request !4259
-
Robert Speicher authored
Update rubocop to 0.40.0 See merge request !4258
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Robert Speicher authored
Enable Style/InfiniteLoop Rubocop cop This MR enabled Style/InfiniteLoop Rubocop cop, and fixes offenses. See https://gitlab.com/gitlab-org/gitlab-ce/issues/17478 See merge request !4257
-
Chris Wilson authored
-
Grzegorz Bizon authored
This enables multiple Rubocop cops that already conform to our codebase and do not require fixes.
-
Robert Speicher authored
Enable Performance/RangeInclude cop and fix single offense Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478 See merge request !4255
-
Robert Speicher authored
-
Robert Speicher authored
Enable Performance/StartWith cop and fix offenses Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478 See merge request !4256
-
Robert Speicher authored
-
Jacob Schatz authored
Fix builds page Fixes #17736 Fixes #17703 - Move tags into column - Put column headers back <img src="/uploads/57609fd2d65c3b80f57b32cbbe316653/Screen_Shot_2016-05-23_at_10.20.37_AM.png" width="800px"> See merge request !4249
-
Annabel Dunstone authored
-
Robert Speicher authored
Enable Style/DefWithParentheses cop and fix single offense Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478 See merge request !4254
-