1. 15 Aug, 2016 10 commits
  2. 14 Aug, 2016 1 commit
    • Ahmad Sherif's avatar
      Fix a memory leak caused by Banzai::Filter::SanitizationFilter · 504a3b5e
      Ahmad Sherif authored
      In Banzai::Filter::SanitizationFilter#customize_whitelist, we append
      three lambdas that has reference to the SanitizationFilter instance,
      which in turn (potentially) has a reference to the following chain:
      
      context hash -> Project instance -> Repository instance -> lookup hash
      -> various Rugged instances -> various mmap-ed git pack files.
      
      All of the above is not garbage collected because the array we append
      the lambdas to is the constant
      HTML::Pipeline::SanitizationFilter::WHITELIST.
      504a3b5e
  3. 12 Aug, 2016 21 commits
  4. 11 Aug, 2016 8 commits
    • Robert Speicher's avatar
      Merge branch 'remove-unused-spam-report' into 'master' · 0f6ed843
      Robert Speicher authored
      Remove unused SpamReport model; this was renamed to SpamLog
      
      See merge request !5778
      0f6ed843
    • Kamil Trzcinski's avatar
    • Kamil Trzcinski's avatar
    • Stan Hu's avatar
      Fix bug where destroying a namespace would not always destroy projects · cb8a425b
      Stan Hu authored
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      
      Closes #17893
      cb8a425b
    • Robert Speicher's avatar
      Merge branch '19725-new-pipeline-auto-completion' into 'master' · d4f987b2
      Robert Speicher authored
      Resolve "New pipeline auto-completion"
      
      ## What does this MR do?
      
      Add auto-completion to new pipeline.
      
      ## What are the relevant issue numbers?
      
      Closes #19725 
      
      See merge request !5389
      d4f987b2
    • ula budziszewska's avatar
      Update CHANGELOG · c5aca8b2
      ula budziszewska authored
      c5aca8b2
    • ubudzisz's avatar
      render only commit title · 957632b7
      ubudzisz authored
      update CHANGELOG
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      remove empty lines
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      switch text_field_tag into text_field
      
      add test to new field
      
      switch context into describe
      
      Update CHANGELOG
      
      render only commit title
      
      update CHANGELOG
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      remove empty lines
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      update changelog
      
      Update CHANGELOG
      
      add indetation
      
      add tests to pipeline ref
      
      change file name for tests
      
      change file name for spec tests
      
      remove empty line
      
      rename test it
      
      rename test name
      
      removing unexpected changes
      
      removing unexpected changes2
      
      update changelog
      957632b7
    • Kamil Trzcinski's avatar