- 24 Feb, 2017 40 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
- Moves a duplicate `file_storage?` definition into the common `GitlabUploader` ancestor. - Get the `uploads` base directory from a class method rather than hard-coding it where it's needed. This will be used in a subsequent MR to store Uploads in the database. - Improves the specs for uploaders.
-
Fatih Acet authored
Adds confirmation for cancel button Closes #28419 See merge request !9519
-
Alfredo Sumaran authored
Removes label from previous list Closes #28484 See merge request !9418
-
Alfredo Sumaran authored
Remove require.context from application.js See merge request !9491
-
Filipa Lacerda authored
Added user-callouts Closes #27269 See merge request !9249
-
Alfredo Sumaran authored
Remove require.context from profile_bundle See merge request !9492
-
Alfredo Sumaran authored
Remove require.context from protected_branches_bundle See merge request !9493
-
Alfredo Sumaran authored
Remove require.context from snippet_bundle See merge request !9494
-
Alfredo Sumaran authored
Remove require.context from users_bundle See merge request !9496
-
Filipa Lacerda authored
-
Jacob Schatz authored
Removed jQuery UI highlight & autocomplete See merge request !8420
-
Jose Ivan Vargas authored
Also removed eslint disabled rules
-
Filipa Lacerda authored
Resolve "Renamed file tooltip contains html" Closes #28366 See merge request !9374
-
Filipa Lacerda authored
Refactor graphs bundle to ES module syntax See merge request !9502
-
Filipa Lacerda authored
Issue boards card template in JS See merge request !9477
-
Jacob Schatz authored
fixes line number copy issue for unfolded parallel view diff Closes #28367 See merge request !9365
-
Achilleas Pipinellis authored
Fix typo in auth0.md doc Closes #27847 See merge request !9059
-
Douwe Maan authored
Deleting a user shouldn't delete associated issues. Closes #12726 See merge request !7393
-
Sean McGivern authored
Use Namespace#full_path instead of #path where appropriate See merge request !9495
-
Rémy Coutable authored
Simplify variables validation in triggers API See merge request !9506
-
Rémy Coutable authored
Use correct GitLab Prometheus exporter name in docs Closes #28619 See merge request !9503
-
Rémy Coutable authored
Added application password instructions for Gmail/G suite accounts See merge request !9486
-
Achilleas Pipinellis authored
Fix broken links in CI admin area docs See merge request !9507
-
Rémy Coutable authored
clarify Pages custom domain details Closes #28577 See merge request !9457
-
Sean McGivern authored
Api remove owned groups Closes #27937 See merge request !9505
-
Douwe Maan authored
Use persistent name identifier instead of transient in SAML2 documentation Closes #28653 See merge request !9504
-
Douwe Maan authored
-
Achilleas Pipinellis authored
[ci skip]
-
Sean McGivern authored
# Conflicts: # doc/api/v3_to_v4.md
-
Sean McGivern authored
Return 202 with JSON body on async removals on V4 API Closes #3874 See merge request !9449
-
Timothy Andrew authored
-
Timothy Andrew authored
- Add a `destroy_user` ability. This didn't exist before, and was implicit in other abilities (only admins could access the admin area, so only they could destroy all users; a user can only access their own account page, and so can destroy only themselves). - Grant this ability to admins, and when the current user is trying to destroy themselves. Disallow destroying ghost users in all cases. - Modify the `Users::DestroyService` to check this ability. Also check it in views to decide whether or not to show the "Delete User" button. - Add a short summary of the Ghost User to the bio.
-
Timothy Andrew authored
- Have `Uniquify` take a block instead of a Proc/function. This is more idiomatic than passing around a function in Ruby. - Block a user before moving their issues to the ghost user. This avoids a data race where an issue is created after the issues are migrated to the ghost user, and before the destroy takes place. - No need to migrate issues (to the ghost user) in a transaction, because we're using `update_all` - Other minor changes
-
Timothy Andrew authored
The default (false) is not strictly required, and this lets us avoid a potentially expensive migration
-
Timothy Andrew authored
1. Refactoring and specs in the `Uniquify` class. 2. Don't use the `AdvisoryLocking` class. Similar functionality is provided (backed by Redis) in the `ExclusiveLease` class.
-
Timothy Andrew authored
Rather than using a separate `ghost` state. This lets us have the benefits of both ghost and blocked users (ghost: true, state: blocked) without having to rewrite a number of queries to include cases for `state: ghost`.
-
Timothy Andrew authored
1. Use an advisory lock to guarantee the absence of concurrency in `User.ghost`, to prevent data races from creating more than one ghost, or preventing the creation of ghost users by causing validation errors. 2. Use `update_all` instead of updating issues one-by-one.
-
Timothy Andrew authored
1. Create a `Uniquify` class, which generalizes the process of generating unique strings, by accepting a function that defines what "uniqueness" means in a given context. 2. WIP: Make sure tests for `Namespace` pass, add more if necessary. 3. WIP: Add tests for `Uniquify`
-
Timothy Andrew authored
- "Associated" issues are issues the user has created + issues that the user is assigned to. - Issues that a user owns are transferred to a "Ghost User" (just a regular user with `state = 'ghost'` that is created when `User.ghost` is called). - Issues that a user is assigned to are moved to the "Unassigned" state. - Fix a spec failure in `profile_spec` — a spec was asserting that when a user is deleted, `User.count` decreases by 1. After this change, deleting a user creates (potentially) a ghost user, causing `User.count` not to change. The spec has been updated to look for the relevant user in the assertion.
-