- 12 Aug, 2016 40 commits
-
-
Fatih Acet authored
-
Fatih Acet authored
-
Sean McGivern authored
- Add match line header to expected result for `File#sections`. - Lowercase CSS colours. - Remove unused `diff_refs` keyword argument. - Rename `parent` -> `parent_file`, to be more explicit. - Skip an iteration when highlighting.
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Fatih Acet authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
Robert Speicher authored
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since `container_registry_path_with_namespace` is the wrong value. The fix is to destroy the group asynchronously and run `execute` directly on Projects::DestroyService. Closes #17893 See merge request !4341
-