- 04 Nov, 2016 9 commits
-
-
Alfredo Sumaran authored
Cleaned up global namespace JS Original MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6229 ## What does this MR do? Cleans up javascript global namespace by moving the functions that were previously on the window.doSomething namespace ## Are there points in the code the reviewer needs to double check? None that I'm aware of ## Why was this MR needed? Improves code maintainability and deals with some of the technical debt ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [X] All builds are passing - [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [X] Branch has no merge conflicts with `master` (if you do - rebase it please) - [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #19661 See merge request !7208
-
Alfredo Sumaran authored
Add tip for using Chrome to run and debug teaspoon tests. ## What does this MR do? Documents the approach I use when writing and debugging frontend tests, which is (IMHO) much better than running locally from the command line. See merge request !7257
-
Alfredo Sumaran authored
Ignore `builds` directory from eslint Running `rake eslint` locally was including this directory reporting so many errors that are not from our source code. See merge request !7279
-
Alfredo Sumaran authored
-
José Iván authored
Moved most of the functions that contained "window.doSomething" that were located at: - app/assets/javascripts/application.js To the following file: - app/assets/javascripts/lib/utils/common_utils.js The functions listed here: - window.ajaxGet - window.split - window.extractLast - window.rstrip - window.disableButtonIfEmptyField - window.disableButtonIfAnyEmptyField - window.sanitize - window.unbindEvents - window.shiftWindow Now will be accessible from the "gl.utils" namespace
-
Bryce Johnson authored
-
Alfredo Sumaran authored
eslint: Fix invalid filename validation Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced. ``` /builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6 2:1 error Filename 'gl_field_error.js.es6' does not match the naming convention filenames/match-regex ``` This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$` This new regex allows the following filenames to pass as valid: - `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js` - `gl_foo_bar.js` which base name translates to `gl_foo_bar` - `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific) See merge request !7281
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
- 03 Nov, 2016 31 commits
-
-
Fatih Acet authored
Add new icon for skipped builds; show created state in mini graph   Closes #22914 See merge request !7276
-
Fatih Acet authored
Hides registry if project repository is disabled ## What does this MR do? When disabling the projects repository it now hides the container registry as well. ## Screenshots (if relevant)   ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/19734#note_17224181 See merge request !7036
-
Fatih Acet authored
Unify dropdown button styles Unifies dropdown styles across app (use one shade of gray for border, always use caret instead of chevron) Before:  After:  Should affect _all_ dropdowns  See merge request !7250
-
Alfredo Sumaran authored
This allows us to pass .js.es6 files as valid filenames;
-
Alfredo Sumaran authored
-
Fatih Acet authored
Add custom text to column Before:  After:  Closes #24133 See merge request !7269
-
Alfredo Sumaran authored
Remove underline focus state on statuses Before:  After:  See merge request !7244
-
Robert Speicher authored
DRY up the bin/changelog specs Depends on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7252 See merge request !7253
-
Sean McGivern authored
Fixes #24102 See merge request !7267
-
Annabel Dunstone Gray authored
-
Rémy Coutable authored
Add and update .gitignore & .gitlab-ci.yml templates for 8.14 Following https://gitlab.com/gitlab-org/gitlab-ce/issues/24134 See merge request !7272
-
Annabel Dunstone Gray authored
-
Robert Speicher authored
[ci skip]
-
Alfredo Sumaran authored
Adds JavaScript validation for group path editing ## What does this MR do? - Prevents group_edit form submission when special characters are included in the new group name - Enhances gl_field_errors to support this use case and be more re-usable. ## Are there points in the code the reviewer needs to double check? **The implementation of validation is here: https://gitlab.com/gitlab-org/gitlab-ce/commit/73d997046cac376ccdbcaac6f183002bc19b9a1f** The rest of the diff for this MR is augmenting gl_field_errors ## Why was this MR needed? - Currently we allow submission and a 500 error is returned. ## Screenshots (if relevant)  ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922 See merge request !7041
-
Robert Speicher authored
-
Annabel Dunstone Gray authored
-
Annabel Dunstone Gray authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Annabel Dunstone Gray authored
-
Rémy Coutable authored
Don't include Gitlab::Routing.url_helpers on top-level namespace (fix error for url_for) ## What does this MR do? Tries to fix: ``` ActionView::Template::Error: arguments passed to url_for can't be handled. Please require routes or provide your own implementation ``` One of the failed build: https://gitlab.com/gitlab-org/gitlab-ce/builds/5825797 See merge request !7265
-
Rémy Coutable authored
Expose more info for SystemHooks See merge request !6964
-
Alejandro Rodríguez authored
-
Rémy Coutable authored
Update "Installation from source" guide for 8.14.0 Following the steps from https://gitlab.com/gitlab-org/release-tools/blob/master/doc/release-candidates.md#creating-rc1. See merge request !7271
-
Alejandro Rodríguez authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Douwe Maan authored
Fix symlink vulnerability in Import/Export Replaces https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2018 made by @james Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23822 See merge request !2022 Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Douwe Maan authored
Fix Import/Export foreign key issue to do with project members Cleans-up any foreign keys in `ProjectMember` - same as we do with the rest of the models when importing. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23837 and https://gitlab.com/gitlab-org/gitlab-ce/issues/23739 See merge request !2020 Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Lin Jen-Shin authored
-
Robert Speicher authored
[ci skip]
-
Lin Jen-Shin authored
-
Robert Speicher authored
[ci skip]
-