1. 05 Jan, 2017 3 commits
    • Lin Jen-Shin's avatar
      Just trust set_commit_variables to set everything! · ae86a1b9
      Lin Jen-Shin authored
      Removing those weird setup in assign_change_commit_vars
      fixed all the failures in the tests. I still cannot say
      why but clearly we need to have better names. It's so
      confusing right now. We should seriously stop fiddling
      those instance variables.
      ae86a1b9
    • Lin Jen-Shin's avatar
      Prefer leading dots over trailing dots · 5e12b3d8
      Lin Jen-Shin authored
      5e12b3d8
    • Lin Jen-Shin's avatar
      Merge request terms are reversed for GitOperationService · 0b3b56b3
      Lin Jen-Shin authored
      This is seriously confusing but a target branch in merge request,
      is actually the source branch for GitOperationService, which is
      the base branch. The source branch in a merge request, is the
      target branch for GitOperationService, which is where we want to
      make commits.
      
      Perhaps we should rename source branch in GitOperationService to
      base branch, and target branch to committing branch.
      0b3b56b3
  2. 04 Jan, 2017 14 commits
  3. 03 Jan, 2017 23 commits