1. 03 Aug, 2016 6 commits
    • Jacob Vosmaer's avatar
      Stop 'git push' over HTTP early · b8f754dd
      Jacob Vosmaer authored
      Before this change we always let users push Git data over HTTP before
      deciding whether to accept to push. This was different from pushing
      over SSH where we terminate a 'git push' early if we already know the
      user is not allowed to push.
      
      This change let Git over HTTP follow the same behavior as Git over
      SSH. We also distinguish between HTTP 404 and 403 responses when
      denying Git requests, depending on whether the user is allowed to know
      the project exists.
      b8f754dd
    • Fatih Acet's avatar
      Merge branch 'fix-filter-input-alignment' into 'master' · 132a81f4
      Fatih Acet authored
      Fix filter input alignment
      
      ## What does this MR do?
      If you carefully observe the filter inputs on the [issues page](https://gitlab.com/gitlab-org/gitlab-ce/issues) and the [projects dashboard page](https://gitlab.com/dashboard/projects), you will notice that those input fields are actually a few pixels lower than the UI elements beside them (More so for the projects dashboard page than the issues page). This MR fixes that alignment issue so that they are aligned to the buttons on their right.
      
      ## Are there points in the code the reviewer needs to double check?
      Shouldn't be
      
      ## Why was this MR needed?
      Improves the existing UI
      
      ## What are the relevant issue numbers?
      Closes #20559 
      
      ## Screenshots (if relevant)
      Before
      ![Screen_Shot_2016-08-02_at_5.42.28_PM](/uploads/8530fc6c9ce20f28ae74b950bc1bd6be/Screen_Shot_2016-08-02_at_5.42.28_PM.png)
      
      After
      ![Screen_Shot_2016-08-02_at_5.49.28_PM](/uploads/ec20e68045c2190aec52e5f059d1a3bc/Screen_Shot_2016-08-02_at_5.49.28_PM.png)
      
      After (with color markings)
      ![Screen_Shot_2016-08-02_at_5.49.25_PM](/uploads/6e032b1ffb438018f6fadf294c3cebd3/Screen_Shot_2016-08-02_at_5.49.25_PM.png)
      
      Before
      ![Screen_Shot_2016-08-02_at_5.41.19_PM](/uploads/11a3c30d0290328bb3298bc392facf9f/Screen_Shot_2016-08-02_at_5.41.19_PM.png)
      
      After
      ![Screen_Shot_2016-08-02_at_5.49.47_PM](/uploads/f8e20346a19dc67cc3e54788dc0e72fb/Screen_Shot_2016-08-02_at_5.49.47_PM.png)
      
      After (with color markings)
      ![Screen_Shot_2016-08-02_at_5.49.58_PM](/uploads/1839d5681ab2f3518609004511af86a6/Screen_Shot_2016-08-02_at_5.49.58_PM.png)
      
      ## Does this MR meet the acceptance criteria?
      
      - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - Tests
        - [x] All builds are passing
      - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !5633
      132a81f4
    • Achilleas Pipinellis's avatar
      Merge branch 'doc-markdown-move' into 'master' · e63729d9
      Achilleas Pipinellis authored
      Move markdown doc to the right location
      
      
      
      See merge request !5635
      e63729d9
    • Achilleas Pipinellis's avatar
      Move markdown doc to the right location · 1a9431b9
      Achilleas Pipinellis authored
      [ci skip]
      1a9431b9
    • Jacob Schatz's avatar
      Merge branch 'discussion-reply-button-performance' into 'master' · 195b20e1
      Jacob Schatz authored
      Remove delay when hitting Reply... button on page with a lot of comments
      
      Every time the "Reply..." button was hit, a new `GLForm` was instantiated (which is fine), which would then call `GitLab.GfmAutoComplete.setup()` without specifying which textarea we needed autocompletion on, which resulted in `GitLab.GfmAutoComplete.setup` iterating through every single textarea on the page. On a page with a lot of comments, where each comment would have its own textarea that will be used to edit the comment, this would take a long time and cause the whole page to hang for 2 seconds when a  "Reply..." button was clicked.
      
      See merge request !5602
      195b20e1
    • Jacob Schatz's avatar
      Merge branch 'convert-trans-bg-to-css' into 'master' · 35529007
      Jacob Schatz authored
      Convert image diff background image to CSS
      
      ## What does this MR do?
      Replaces the `trans_bg.gif` image used for image diff background image with a CSS implementation of the same background image
      
      ## Are there points in the code the reviewer needs to double check?
      None
      
      ## Why was this MR needed?
      Uses CSS to replace the use of an image so that webpage rendering is slightly improved
      
      ## What are the relevant issue numbers?
      Closes #20500 
      
      ## Screenshots (if relevant)
      Before:
      ![Screen_Shot_2016-08-01_at_12.29.10_PM](/uploads/8269877c561c29e6b0ca988079ff3fc6/Screen_Shot_2016-08-01_at_12.29.10_PM.png)
      
      After:
      ![Screen_Shot_2016-08-01_at_12.29.16_PM](/uploads/cc88848b9c0e044445d19b889fd79271/Screen_Shot_2016-08-01_at_12.29.16_PM.png)
      
      ## Does this MR meet the acceptance criteria?
      
      - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !5598
      35529007
  2. 02 Aug, 2016 34 commits