Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626479

* upstream/master:
  Ensure we have a project with a repo in GitlabMarkdownHelper specs
  Revert "Make sure TraceReader uses Encoding.default_external"
  Make sure TraceReader uses Encoding.default_external
  Update CONTRIBUTING.md after merging "up-for-grabs" and "Accepting Merge Requests" [ci skip]
  Use `:empty_project` where possible in finder specs
  Use `empty_project` where possible in controller specs
  Use `:empty_project` where possible in helper specs
  Don’t count tasks that are not defined as list items correctly
  Use a project factory with a repository where necessary
  Use `:empty_project` where possible throughout spec/lib
  Use hashrocket for dasherized attribute
  Remove markdown file extension and add anchor to link
  Fixed builds info link on project settings page
  Factories with a project association use `:empty_project` by default
  Update enviroments.md the example for deleting an environment is missing the "s" in environments. curl --request DELETE --header "PRIVATE-TOKEN: 9koXpg98eAheJpvBs5tK" "https://gitlab.example.com/api/v3/projects/1/environments/1"  wil 404

Update enviroments.md API docs

The example for deleting an environment is missing the "s" in environments

See merge request !8485

Ensure we have a project with a repo in GitlabMarkdownHelper specs

Closes #27285

See merge request !8806

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21627134

Update CONTRIBUTING.md after merging "up-for-grabs" and "Accepting Merge Requests"

See merge request !8802

Use `:empty_project` where possible throughout spec/lib

See merge request !8767

Signed-off-by: Rémy Coutable <remy@rymai.me>

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21627207

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626953
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626952

Fixed builds info link on project settings page

Closes #27178

See merge request !8762

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_21626434

don’t count tasks that are not defined as list items correctly

Closes #26068

See merge request !8526

This reverts commit e9d8fc94.

Encoding.default_external was chosen over
Encoding.default_internal because File.read is
returning Encoding.default_external, therefore
we should align with it. Alternatively, we could
force both of them to be Encoding.default_internal.

However, ideally this should be determined by different
projects. For example, some projects might want to use
an encoding different to what GitLab is using.

This might not happen soon though.

Closes #27052

* upstream/master: (1122 commits)
  Update CHANGELOG.md for 8.16.2
  Display project ID in project settings (!8572)
  fixed points from comments to improve code quality
  Update CHANGELOG.md for 8.14.8
  Statisfy eslint
  Add CHANGELOG entry
  Fix access to the wiki code via HTTP when repository feature disabled
  Display fullscreen button on small screens (!5302)
  Prevent removing fields from dropdowns on input elements
  fix for all themes
  Return struct instead of multiple values
  Fix race conditions for AuthorizedProjectsWorker
  Add User#nested_groups and User#nested_projects methods
  Fix spec failure due to timestamp ordering issue in mySQL
  Fixed error with filter keyboard tests
  `can?` already includes the `feature_available?` check
  Test there is no Merge Request button when MRs are disabled
  Ensure the correct Merge Request button is found
  Add 409 conflict tests
  Add CHANGELOG
  ...

Factories with a project association use `:empty_project` by default

See merge request !8770

Use `:empty_project` where possible in helper specs

See merge request !8796

Use `:empty_project` where possible in controller specs

See merge request !8797

Use `:empty_project` where possible in finder specs

See merge request !8794

Use hashrocket for dasherized attribute

Closes #27203

See merge request !8775

[ci skip]

Resolve "regression in commit title bar"

Closes #27013

See merge request !8751

Resolve "Branch index delete button inconsistently spaced and misaligned"

Closes #24895

See merge request !8646

Display project ID

Closes #18350

See merge request !8572

Fix access to the wiki code via HTTP when repository feature disabled

Closes #26518

See merge request !8758

Copying a rendered issue/comment will paste into GFM textareas as actual GFM

See merge request !8597

Color + and - signs in diffs to increase code legibility

Closes #26186

See merge request !8768

Resolve "Line numbers now in copy pasta data"

Closes #27021

See merge request !8706

Fix race conditions for AuthorizedProjectsWorker

Closes #26194 and #26310

See merge request !8701

[ci skip]

Fixed label select toggle not updating correctly

Closes #26119

See merge request !8601