An error occurred fetching the project authors.
- 01 Jun, 2016 1 commit
-
-
Stan Hu authored
A user viewing the TODOs page will see a 404 if there are mentioned labels in multiple different projects. This is likely a caching bug and only occurs when Markdown rendering occurs across multiple projects, which is why it's so tricky to reproduce. This is what I think is happening: 1. LabelReferenceFilter#references_in encounters label ~X for ProjectA and finds the label in the DB as id = 1. 2. LabelReferenceFilter.references_in yields [1, 'X', nil, ...] 3. Since project_ref is nil, AbstractReferenceFilter#project_from_ref_cache caches nil => ProjectA. 4. LabelReferenceFilter#references_in encounters label ~Y for ProjectB and finds the label in the DB as id = 2. 5. LabelReferenceFilter.references_in yields [2, 'Y', nil, ...] 6. AbstractReferenceFilter#project_from_ref_cache lookups nil and returns ProjectA. It was supposed to be ProjectB. 7. A is the wrong project, so the label lookup fails. This MR caches Markdown references if the key is present. Closes #17898
-
- 31 May, 2016 3 commits
-
-
Gabriel Mazetto authored
-
Kamil Trzcinski authored
- 30 May, 2016 3 commits
-
-
Gabriel Mazetto authored
-
Kamil Trzcinski authored
-
Stan Hu authored
Closes #17920
-
- 29 May, 2016 2 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 28 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
fixes #17508
-
- 27 May, 2016 3 commits
-
-
Ben Yorke authored
-
James Lopez authored
-
Jacob Vosmaer authored
-
- 26 May, 2016 2 commits
-
-
Josh Frye authored
-
James Lopez authored
-
- 25 May, 2016 11 commits
-
-
Robert Speicher authored
[ci skip]
-
Robert Speicher authored
[ci skip]
-
DJ Mountney authored
Switch the gitlab:db:configure task to use tables.any? instead of looking specifically for the schema_migrations table
-
DJ Mountney authored
-
Felipe Artur authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
Signed-off-by:
Alfredo Sumaran <alfredo@gitlab.com>
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Stan Hu authored
Closes #17496
-
- 24 May, 2016 5 commits
-
-
Felipe Artur authored
-
Aran Koning authored
-
Stan Hu authored
[ci skip]
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 23 May, 2016 7 commits
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
James Lopez authored
-
Stan Hu authored
Closes #17730
-
Grzegorz Bizon authored
-
Robert Speicher authored
[ci skip]
-
Robert Speicher authored
[ci skip]
-
- 22 May, 2016 2 commits
-
-
Grzegorz Bizon authored
-
Kamil Trzcinski authored
-