1. 03 Dec, 2019 18 commits
    • Jérome Perrin's avatar
      accounting_simulation_legacy: format AccountingRuleCell properly · 9aa6b278
      Jérome Perrin authored
      pylint complained about indentation
      9aa6b278
    • Jérome Perrin's avatar
      accounting_simulation_legacy: restore AccountingRuleCell · 5d206c29
      Jérome Perrin authored
      this was removed in 2138aee5
      5d206c29
    • Jérome Perrin's avatar
      banking_inventory: skip coding style test · e8574779
      Jérome Perrin authored
      This bt has too many coding style problems for now
      e8574779
    • Jérome Perrin's avatar
      travel_expense: fix duplicate selection names · 03029bcb
      Jérome Perrin authored
        'ticket_view_selection'
      	'Tickect_viewRelatedRecordList/listbox': set(['erp5_hr_request'])
      	'Ticket_view/listbox': set(['erp5_crm'])
      03029bcb
    • Jérome Perrin's avatar
      officejs_ooffice: fix duplicate selection names · 2e272917
      Jérome Perrin authored
        'web_page_module_view_web_page_list_selection'
      	'DocumentModule_viewDocumentListAsJioForOofficeSpreadsheetEditor/listbox': set(['erp5_ooffice_spreadsheet_editor'])
      	'DocumentModule_viewDocumentListAsJioForOofficePresentationEditor/listbox': set(['erp5_ooffice_presentation_editor'])
      	'WebPageModule_viewWebPageList/listbox': set(['erp5_web'])
      	'DocumentModule_viewDocumentListAsJioForOofficeTextEditor/listbox': set(['erp5_ooffice_text_editor'])
      	'WebPageModule_viewWebTableListAsJioForWebTableEditor/listbox': set(['erp5_web_table_editor'])
      2e272917
    • Jérome Perrin's avatar
      officejs_jquery_app: fix duplicate selection name · e0591aeb
      Jérome Perrin authored
        'image_selection'
      	'ImageModule_viewImageList/listbox': set(['erp5_dms'])
      	'ImageModule_viewImageListAsJioForImageEditor/listbox': set(['erp5_image_editor'])
        'web_page_module_view_web_page_list_selection'
      	'DocumentModule_viewDocumentListAsJioForOofficeSpreadsheetEditor/listbox': set(['erp5_ooffice_spreadsheet_editor'])
      	'DocumentModule_viewDocumentListAsJioForOofficePresentationEditor/listbox': set(['erp5_ooffice_presentation_editor'])
      	'WebPageModule_viewWebPageList/listbox': set(['erp5_web'])
      	'DocumentModule_viewDocumentListAsJioForOofficeTextEditor/listbox': set(['erp5_ooffice_text_editor'])
      	'WebPageModule_viewWebTableListAsJioForWebTableEditor/listbox': set(['erp5_web_table_editor'])
      e0591aeb
    • Jérome Perrin's avatar
      research_item: fix missing selection name · 064a7095
      Jérome Perrin authored
      064a7095
    • Jérome Perrin's avatar
      tests: don't skip testLive* testVifib* · 0b951ab6
      Jérome Perrin authored
      There are no testVifib (at least not in nexedi/erp5 repository) and
      there is only one testLive that there is no reason to skip.
      0b951ab6
    • Jérome Perrin's avatar
      ingestion_test: fix pylint errors in testLiveIngestion · 58abc9d6
      Jérome Perrin authored
      This test never ran because we skip testLive*
      58abc9d6
    • Jérome Perrin's avatar
      ingestion: split erp5_ingestion in erp5_ingestion_test · 3fb72f4f
      Jérome Perrin authored
      erp5_ingestion contained a skin folder for tests, with some proxy fields depending on erp5_web.
      There was a proper test dependency to erp5_web, but in static analysis check we now check the skin folders, so it's no longer allowed to have some skin folder that are broken without test dependencies but not supposed to be used outside of tests.
      3fb72f4f
    • Jérome Perrin's avatar
      hr: fix proxy fields · 3487504f
      Jérome Perrin authored
      Since this was using proxy fields from erp5_crm, add dependency on CRM.
      Update to the new name of CRM field library.
      3487504f
    • Jérome Perrin's avatar
      video: fix <video> editor field · 16eb9ae3
      Jérome Perrin authored
      nuvalidator complains that:
        Bad value “true” for attribute “autoplay” on element “video”
      
      This could probably be switched to VideoField now.
      16eb9ae3
    • Jérome Perrin's avatar
      VideoField: make valid HTML5 regarding preload · 657bcc2e
      Jérome Perrin authored
      Unlike other attributes managed in video field, preload [1] is not a
      boolean attribute, so setting preload="preload" was invalid HTML5.
      
      On the field, we can only configure video_preload as a boolean
      attribute, setting preload="auto" when true and not setting preload when
      False seems the closest meaning of True/False.
      
      [1] https://html.spec.whatwg.org/multipage/media.html#attr-media-preload
      657bcc2e
    • Jérome Perrin's avatar
      tiosafe_core: depend on erp5_accounting · 8e99c75b
      Jérome Perrin authored
      IntegrationSite_view/my_source_payment is a proxyfield to a field in
      erp5_accounting.
      8e99c75b
    • Jérome Perrin's avatar
      post: depend on crm · 668d61df
      Jérome Perrin authored
      It uses proxy fields from erp5_crm
      668d61df
    • Jérome Perrin's avatar
      project_ui: fix duplicate selection names · 8169baee
      Jérome Perrin authored
         'base_view_document_selection'
      	'Base_viewDocumentList/listbox': set(['erp5_core'])
      	'Project_viewDocumentList/listbox': set(['erp5_web_project'])
         'project_module_selection'
      	'ProjectModule_viewProjectList/listbox': set(['erp5_project'])
      	'ProjectModule_viewProjectManagementList/listbox': set(['erp5_web_project'])
      8169baee
    • Jérome Perrin's avatar
      officejs: fix duplicate selection names · 4699cc45
      Jérome Perrin authored
      These selection names were already used in other business templates:
      
         'web_page_module_view_web_page_list_selection'
      	'WebPageModule_viewWebPageListAsJioForCodemirror/listbox': set(['erp5_officejs_codemirror'])
      	'WebPageModule_viewWebPageListAsJioForTextEditor/listbox': set(['erp5_text_editor'])
      	'WebPageModule_viewWebPageList/listbox': set(['erp5_web'])
      	'DocumentModule_viewDocumentListAsJioForPdfViewer/listbox': set(['erp5_officejs_pdf_viewer'])
         'image_selection'
      	'WebPageModule_viewWebPageListAsJioForSvgEditor/listbox': set(['erp5_officejs_svg_editor'])
      	'ImageModule_viewImageList/listbox': set(['erp5_dms'])
      4699cc45
    • Jérome Perrin's avatar
      monaco_editor_ui_test: repair test · 041b0614
      Jérome Perrin authored
      Now ERP5JS display list mode header only if the jio key does not contain
      /, so if we open a module with a hand-made URL with a trailing slash,
      it's no longer seen as a module.
      
      Repair this test by using a URL without that trailing / in the key.
      041b0614
  2. 02 Dec, 2019 10 commits
  3. 28 Nov, 2019 12 commits
    • Sebastien Robin's avatar
      69b88b4b
    • Jérome Perrin's avatar
      administration: fixes for pylint · 00e1736b
      Jérome Perrin authored
      00e1736b
    • Jérome Perrin's avatar
      ERP5Type: define ConstraintMixin._checkConsistency · 592e3eae
      Jérome Perrin authored
      Without this, subclassing defining this method will have arguments-differ
      pylint warning because the signature of Base._checkConsistency is
      different.
      592e3eae
    • Jérome Perrin's avatar
      forge/administration: move some scripts to administration · ca05b59a
      Jérome Perrin authored
      These scripts are used to check the site configuration and also in
      CodingStyleTest.
      
      This is just the minimal so that CodingStyleTest can run, but this could
      be extended to several scripts currently in erp5_toolbox skinfolder of
      erp5_forge which overlaps with erp5_administration. Also, regarding
      CodingStyleTest, it seems that erp5_administration contain a lot of
      things, so we may want to extract a smaller business template containing
      only the scripts used for static analysis of business template.
      ca05b59a
    • Jérome Perrin's avatar
      administration: include new component types in "check source code" · 783add94
      Jérome Perrin authored
      We want this check to run on all components.
      783add94
    • Jérome Perrin's avatar
      CodingStyle: ignore more skins and prefixs · a4e0fb2d
      Jérome Perrin authored
      Module is an acceptable prefix for modules
      
      Introduce a list of skins IDs that does not match our conventions but
      are acceptable because this is what external API are calling.
      a4e0fb2d
    • Jérome Perrin's avatar
      testXHTML: test portal types also from tools · 56e16adc
      Jérome Perrin authored
      Some portal types such as Business Template were not tested by testXHTML
      because this tests started by modules and recursively tests views based
      on allowed content types. Because of this approach, types that are not
      created in a module but in a tool were never tested.
      
      With unittest, the only way to dynamically add test methods to a class
      is to generate a test class in test_suite function. At this stage, the
      ERP5 site is not created yet, so the test had to introspects business
      templates XML.
      
      This now uses a slightly different approach, instead of finding modules
      and chain of allowed content types from business template XML, we only
      use business template to introspect the list of actions.
      The lookup of the appropriate containers is no longer done before setup
      by static analysis of business templates XML, but later once the site is
      created, by dynamic analysis of the modules and allowed content types on
      the running ERP5 site during the test method.
      If we don't find a chain of portal types, we create the test document in
      portal_trash, a tool without filter of content types.
      
      This way, we can test all views of all portal types. This revealed a few
      problems:
       - we need developer role to create components in portal_components, for
      this we add developer role to the current user.
       - Delivery Cell portal type looks not used, there are no container
      accepting it. We don't test delivery cell views for this reason.
       - VCS view on business template needs preferences and working copy
      setup. We just mark this test as expected failure for now.
       - Solver Decision has a form conditionnaly displayed when there's a
      relation to a solver, but this test does not evaluate action conditions
      and does not allow to call a script (that would made it possible to
      modify the document so that the condition is true). For now we also
      mark this as expected failure.
      56e16adc
    • Jérome Perrin's avatar
      immobilisation: remove views from Delivery Cell · 439745de
      Jérome Perrin authored
      Delivery Cell is not really used these days and cannot be created in
      testXHTML, so drop these useless views.
      
      For reference, the same views still exists on all other movements portal
      types, so we don't "loose anything important" by removing the views
      here.
      439745de
    • Jérome Perrin's avatar
      budget: mark Budget Transfer view not visible · 36a87f63
      Jérome Perrin authored
      The corresponding form, BudgetTransfer_viewBudgetTransferLine does not
      exist, so mark view as not visible for now so that it's not tested.
      36a87f63
    • Jérome Perrin's avatar
      base: make Geographical Location "View on map" a jump action · d095b939
      Jérome Perrin authored
      This redirects to another site, so it is not really a view action.
      
      This also confuses testXHTML.
      d095b939
    • Jérome Perrin's avatar
      8ceb8452
    • Jérome Perrin's avatar
      core: support non initialized cache when viewing cache statistics · d88ec10f
      Jérome Perrin authored
      Maybe what's missing is an interaction to update cache internals with
      updateCache when a cache is added, but that's enough to make TestXHTML
      pass now.
      d88ec10f