- 27 Dec, 2019 1 commit
-
-
Arnaud Fontaine authored
-
- 26 Dec, 2019 15 commits
-
-
Vincent Pelletier authored
Especially important as the deleted document has an hard-coded ID which gets reused - as is the case here. It may not be a good idea to hardcode such ids in tests too, but I cannot judge at a glance. /cc @romain /reviewed-on !1020
-
Jérome Perrin authored
Assorted fixes for minor issues with ZODB History tab: 1. When viewing history of a website or websection in the "backoffice" interface, clicking on *View ZODB History* does not keep the `ignore_layout:int=1` request parameter that forces displaying the forms in the *View* skin selection. 2. Fix using ZODB history for documents with binary properties, such as `data` property on images and files. Instead of failing with unicode error, just display "(binary)". 3. Put the link field in center group, forms with only fields in left group and nothing in right group have a border only on the left side. ( this is https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group ) see before: ![before__1_](/uploads/eaafe271228e960f58b7b928cb517ac9/before__1_.png) and after: ![Screenshot_2017-11-28_at_19.32.09](/uploads/bdd0adcc80b138dca7ddcb45b2ff184a/Screenshot_2017-11-28_at_19.32.09.png) /reviewed-on nexedi/erp5!512
-
Jérome Perrin authored
This is enabled for title and description only, because that's usually what we put on "external" documents such as invoices. By "resource" here it means products, services, components and their individual variations In short, change the translation configuration from ![Screenshot_2017-12-05_at_10.22.39](/uploads/2c72a0b35dbbde1ec6d7156f2e2f372a/Screenshot_2017-12-05_at_10.22.39.png) to ![Screenshot_2017-12-05_at_10.23.31](/uploads/d86c2fce6a9d134e17b5fddc983491a3/Screenshot_2017-12-05_at_10.23.31.png) /reviewed-on !515
-
Jérome Perrin authored
Fix broken tests after !1011 it was merged too fast. /reviewed-on nexedi/erp5!1018
-
Jérome Perrin authored
Some users have been using google chrome builtin translation system with ERP5 back office (xhtml style), but the way google translation changes the DOM sometimes break ERP5 interface. This also have data privacy issue as this translation is done on google servers. https://www.w3.org/International/questions/qa-translate-flag recommends using translate=no but the approach of the meta tag might be preferable for our case as it prevents sending the page content to translation service. /reviewed-on nexedi/erp5!879
-
Jérome Perrin authored
The field needs to be in center group to comply with https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group
-
Jérome Perrin authored
It was failing decoding unicode
-
Jérome Perrin authored
-
Jérome Perrin authored
Otherwise we cannot use this feature on a website/websection using a different skin selection.
-
Jérome Perrin authored
3d3ee5da had syntax error and test were not updated for new behavior
-
Jérome Perrin authored
content_type is a bit special, because CMF's PortalFolderBase also have a content_type method, so this was confusing ERP5Type dynamic properties system. When the property was never set, the default value was the method acquired from PortalFolderBase. Fixes this by defining conten_type class attribute where needed. This also fixes an old expected failure test, it's now possible to use edit(content_type=something) in document without content type property set. It works now, but thanks to what seems to be outdated code in _valid_property_id from product/ERP5Type/patches/PropertyManager.py, because we have stopped setting all properties to None in Base years ago. For now, this works, but because of an outdated condition in _valid_property_id. We may revisit later in the future.
-
Vincent Pelletier authored
Safe activities are: - those which are not visible outside current transaction (IOW, queued in activity buffer) - those which are already marked as failed, as no activity node will try to process these Other activities may already be running. Note: deleting even failed activities may violate activity dependencies (other activities may be waiting on the ones being deleted, even those not spawned yet), but if this is an issue then some other code should take care of these as well. Also, rework a CMFActivity test checking that activties already-spawned on a later-deleted context get discarded instead of being executed: previous implementation was working around the activity deletion removed in this commit. Also, test indexation/unindexation parallelism.
-
Vincent Pelletier authored
uids are a way one can signal that different objects (from a ZODB point of view, and hence an oid point of view) are actually to be considered as the same objet (from a higher abstration point of view). For example, another variant of the same object, as imported over an older variant. In turn, this allows extending the protection to activities spawned from brains, and not just from live objects.
-
Nicolas Wavrant authored
To save a bit of time every day (and save us from typos)
-
Nicolas Wavrant authored
As now ERP5 is mainly used though the web interface, the use of the save action is nowadays very limited
-
- 25 Dec, 2019 12 commits
-
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: Remove dead code. keywordsplitter() has never been defined so this code has been broken since its introduction.
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: get_transaction() removed in ZODB 3.6.
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: ResourceLockedError.
-
Arnaud Fontaine authored
-
Jérome Perrin authored
We receive feedback from users saying that "when I view a mail message in event module, I see ugly html source", this was because user had set preferred text editor to monaco. Improve a bit monaco integration so that we display something better than code in a `<pre>` for non editable editors. We had another feedback that when using CKEditor as preferred text editor in old UI, users can not click on links when viewing an html Mail Message. But it works in new UI. I did something minimal so that this looks working until the migration to new UI is complete. /reviewed-on nexedi/erp5!1011
-
Jérome Perrin authored
With the current architecture of cache manifest, it was required that developpers change the cache manifests referencing a web page every time they change a web page. In practice, developers were never doing this, so we sometimes had issues where client keep using old version of website even though a new version has been deployed, when after deployment we did not change the cache manifest. To automate the scenario of modifying the cache manifest, introduce a post-upgrade constraint that will check that the manifest is newer than all of the referenced pages. If that's the case, the constraint can fix by modifying the manifest content, which also changes the modification date of the manifest, which might be used in "if-modified-since" negociations. According to spec [1], cache manifest is updated if the HTTP responses is not "304 not modified" and if the manifest content is not byte-for-byte identical to the previously cached version. [1] https://www.w3.org/TR/2008/WD-html5-20080122/#updating1 /reviewed-on nexedi/erp5!1009
-
Jérome Perrin authored
Post upgrader constraint to automatically fix modification date and an upgrader bug-fix for an issue that's revealed in this new test. /reviewed-on nexedi/erp5!1013
-
Jérome Perrin authored
This tests had a test instance URL hardcoded and was working only on this instance.
-
Thomas Gambier authored
-
Jérome Perrin authored
The default size of iframe is too small for CKEditor to display dialogs properly. Increase the height so that CKEditor display dialog boxes correctly. /reviewed-on nexedi/erp5!1010
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: Followup of 47b14fd4 making sure that there is only one Delivery to update (as it was before that commit).
-
- 24 Dec, 2019 6 commits
-
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Jérome Perrin authored
Web sections or web sites displaying a default page should have modification date after the modification date of their default page, so that the "if-modified-since" requests can be replied with a 304 not modified responses.
-
Jérome Perrin authored
Upgrader detects that if some type have constraints and their container type also have constraint, it's not needed to check again this type because since checkConsistency is recursive when the container is checked they will also be checked. This fails when we have situtations like: X is allowed in Y X is allowed in Z and there are constraints for by X, Y and Z. This was raising a KeyError when pop'ing Z : Module script, line 50, in Base_getConstraintTypeListPerPortalType - <PythonScript at /erp5/Base_getConstraintTypeListPerPortalType used for /erp5/portal_alarms/upgrader_check_pre_upgrade> - Line 50 type_list = constraint_type_per_type.pop(allowed_content_type) Module AccessControl.ZopeGuards, line 104, in guarded_pop v = guarded_getitem(d, key) Module AccessControl.ZopeGuards, line 83, in guarded_getitem v = object[index] KeyError: 'Z' In fact, this code is wrong, because if Z is also allowed in W and W does not have constraint, then Zs inside Ws will not be migrated. In practice, that's probably OK for now, because we don't use migration constraints on documents so much, most of the time we only do one script that checks the constraint globally.
-
- 23 Dec, 2019 1 commit
-
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!1003
-
- 20 Dec, 2019 5 commits
-
-
Romain Courteaud authored
Many typos in: nexedi/erp5@a9d81b09
-
Romain Courteaud authored
-
Boxiang Sun authored
-
Boxiang Sun authored
-
Jérome Perrin authored
In xhtml style, clicking on <a> links in a non editable ck editor does nothing. It's possible to to use Ctrl+right click to trigger the popup menu and "open in new tab", but that's confusing for users. Implement something minimal so that the event handler registered in ck editor gadget also works in html style.
-