GitLab

Kirill Smelkov authored Dec 24, 2021 and Romain Courteaud committed Jan 04, 2022

@romain reports that Popen(close_fds=True) is slow on py2. Let's semantically
backport from py3 how to close only actually opened file descriptors instead of
whole 3..`ulimit -n` range.

Attached test benchmark shows the following results with `ulimit -n`=65K:

Before this patch:

    $ ./bin/python2.7 ~/x.py
    close_fds=False:
    0.001251 s/call
    0.001337 s/call
    0.001486 s/call

    close_fds=True:
    0.017973 s/call
    0.018152 s/call
    0.018204 s/call

After the patch:

    $ ./bin/python2.7 ~/x.py
    close_fds=False:
    0.001391 s/call
    0.001416 s/call
    0.001570 s/call

    close_fds=True:
    0.001469 s/call
    0.001479 s/call
    0.001491 s/call

i.e. ~12x speedup.

References on this subject are in the patch itself.

The test benchmark is below:

---- 8< ----
import timeit
from subprocess import check_call

def f():
    check_call(['true'], close_fds=False)
def g():
    check_call(['true'], close_fds=True)

N=3
n=10...