1. 20 Apr, 2022 1 commit
  2. 16 Apr, 2022 10 commits
  3. 15 Apr, 2022 5 commits
    • Jérome Perrin's avatar
      CodingStyleTest: review business template installation · 1c57528b
      Jérome Perrin authored
      We were installing erp5_upgrader with its test dependencies, so it was
      installing erp5_full_text_mroonga_catalog. We were also installing
      erp5_full_text_myisam_catalog, so we ended up with two full text
      business template installed (and the order of this installation was not
      deterministic).
      This was problematic, because we were installing all the test dependencies
      of erp5_upgrader, but we don't really need them here and one goal of
      CodingStyleTest is to install only the dependencies of tested business
      templates, as a way to verify that dependencies are correctly specified.
      
      This new approach hooks at another level, to install a full text business
      template only if the tested business template has a dependency to the
      virutal "erp5_full_text_catalog" bt, but no dependency to a concrete bt
      (which happens for example in erp5_base) and to install erp5_upgrader
      without its test dependencies.
      
      As a result, we also run without erp5_base unless it's an explicit
      dependency.
      
      This also reverts commit ab44309f (
      full_text_myisam_catalog: skip coding style test) that is no longer
      needed with this new approach.
      1c57528b
    • Jérome Perrin's avatar
      base,core: move RoundingTool and RoundingModel to erp5_core · 13551c2e
      Jérome Perrin authored
      Some other documents from erp5_core import RoundingModel, all this can
      not be in erp5_base
      13551c2e
    • Jérome Perrin's avatar
    • Jérome Perrin's avatar
      core,base: move Base_viewDocument{Searchable,}List to erp5_base · d4184c15
      Jérome Perrin authored
      These forms use proxy fields from erp5_base, they can not be in
      erp5_core.
      d4184c15
    • Jérome Perrin's avatar
      ui_test_core: replace form to update reference snapshot by a download link · 9d0e6a4a
      Jérome Perrin authored
      In case of snapshot test failure, we generated a form in a data:test/html
      link. This was working on chrome at the time, but it no longer work these
      days, probably because we switched to Same-Site cookie for authentication.
      Anyway, this also had the problem that it's not so convenient to use
      when updating the reference from the actual screenshot took from the
      test running on test node.
      
      These change this to generate a simple download link, and the workflow to
      update reference snapshot becomes to click this link to get the new image,
      upload it to development zope instance and re-export the business template.
      9d0e6a4a
  4. 14 Apr, 2022 6 commits
    • Romain Courteaud's avatar
    • Jérome Perrin's avatar
      full_text_myisam_catalog: skip coding style test · ab44309f
      Jérome Perrin authored
      This business template conflicts with full_text_mroonga_catalog, because
      it overrides same paths. Because this bt is generally not recommended
      and might even be removed, it's better not to complicate coding style test
      infrastructure to support this pattern.
      ab44309f
    • Jérome Perrin's avatar
      *: re-export components without the error_message workflow variable · f1a814e2
      Jérome Perrin authored
      follow up of 8a335cca (component: fix error_message saved in every line of history, 2022-02-18)
      f1a814e2
    • Jérome Perrin's avatar
      CodingStyle: verify that business template re-exporting is stable · 7fd94178
      Jérome Perrin authored
      re-exporting a business template that was just installed should not be
      different.
      
      By having a test reporting diffs in export, we can detect changes in ERP5 or
      dependencies which would cause the business template format to become different.
      The primary reason for doing this was to make sure that on the way to Zope4 we
      don't have changes in exported data, especially lossly changes that would not
      be detected in test suite, but this is also good because it helps detecting
      changes that cause a difference in output - then if we introduce a change that
      cause different business template export, we also have to make a change to
      re-export everything to new format, which helps keeping the git history cleaner
      because there's one big commit with all the changes instead of having many small
      commits. This is also good because it detects mistakes when modifying business
      templates files directly with a text editor.
      
      The test can be configured to ignore some paths, using fnmatch pattern (which
      unlike business patterns do not support ** for recursive match). This is also
      helpful when using this test case to check customer configuration business
      templates, where we may want to ignore some PathTemplateItem for conveniance.
      
      This also include fix for almost all current cases where re-exporting produce
      a diff, except a few cases that the reason for the diff was not understood, they
      were added to the ignore list instead.
      
      
      See merge request nexedi/erp5!1575
      7fd94178
    • Jérome Perrin's avatar
      Formulator,xhtml_style: render multi radio and checkboxs with a label · 4086f9a6
      Jérome Perrin authored
      This way, clicking on the label is enough to select the radio button,
      or tick the checkbox, no need to click on the small button.
      This is also probably better for accessibility.
      
      CSS is adjusted a bit, so that the style for "general" field labels
      do not apply to this new label.
      4086f9a6
    • Jérome Perrin's avatar
      *_ui_test: make Zelenium tests compatible with Zope4 ZMI · 87c30a04
      Jérome Perrin authored
      The status message no longer use system-msg class, use simpler
      "assertTextPresent" that should be enough.
      
      Simplify the waiting for static pages, clickAndWait is enough.
      87c30a04
  5. 12 Apr, 2022 1 commit
  6. 11 Apr, 2022 1 commit
  7. 08 Apr, 2022 3 commits
  8. 07 Apr, 2022 2 commits
  9. 05 Apr, 2022 8 commits
  10. 31 Mar, 2022 3 commits