- 17 Sep, 2018 17 commits
-
-
Romain Courteaud authored
Correctly handle multiple interface declarations Reduce DOM modification. Load gadget in an iframe to improve isolation Delay gadget creation to prevent creating hundred of iframes in parallel, which slow down the browser
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Prevent submitting the form if the relation field contains an unknown search string.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Sven Franck authored
-
Sven Franck authored
-
Sven Franck authored
-
Vincent Pelletier authored
_reindexOnCreation API does not expect an expanded activate_kw, but really only an expanded reindex_kw - which may contain its own activate_kw, over which our activate_kw is supposed to take precedence (see Products.ERP5Type.Base.Base._getReindexAndActivateParameterDict). It's all so easy !
-
Vincent Pelletier authored
activate_kw was not honored in immediate indexation code path.
-
Vincent Pelletier authored
Also, tix typo in comment.
-
- 15 Sep, 2018 1 commit
-
-
Julien Muchembled authored
Revert "Folder: call activate on the object instead of portal_activities.activateObject in _recurseCallMethod()." This reverts commits 3d3ec3cb ((+ fixup), which broke recursion to objects that don't inherit ActiveObject, as explained in the docstring. I also think it was wrong in that default activate parameters disappear at the end of the transaction whereas _recurseCallMethod may activate itself to avoid creating to many activities at once. IOW, it's important that created activities are the same no matter where _recurseCallMethod splits the browsing. This change needed more review, as well as a unit test.
-
- 14 Sep, 2018 6 commits
-
-
Sebastien Robin authored
-
Kazuhiko Shiozaki authored
Folder: call activate on the object instead of portal_activities.activateObject in _recurseCallMethod(). so that activate_kw set on the object is respected.
-
Łukasz Nowak authored
The site shall be used with default BT5s.
-
Łukasz Nowak authored
Previous field names came from obsoleted erp5_core_proxy_field_legacy
-
Vincent Pelletier authored
This was the case before commit b41dc8e0 Author: Vincent Pelletier <vincent@nexedi.com> Date: Wed Sep 12 04:00:08 2018 +0200 SQLCatalog_deferFullTextIndex{,Activity}: Use serialization_tag . but I misread the code: when this exception triggered, document was neither added in parameter_dict nor in failed_path_list. It should be now clearer.
-
Vincent Pelletier authored
-
- 13 Sep, 2018 3 commits
-
-
Sebastien Robin authored
This reverts commit fedebf37. Finally, it was an issue in selenium runner software, the wrapper was missing
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 12 Sep, 2018 7 commits
-
-
Vincent Pelletier authored
Also, why make only 2 queries when I can make 2n+1 queries for the same result ?
-
Vincent Pelletier authored
getObject is generally a shortcut for "return self", and on brains for traversing to corresponding document. Except... Not everywhere. portal_catalog for example defines a completely unrelated method which takes a UID as argument and does a query retrieving one document. Which is basically totally redundant with its __call__ method. Still, of course, it is used in several places. Also, ERP5Form.Report defines yet another getObject method, taking an acquisition context as argument and traversing to some other path. So do not use getObject (at least until the code recovers some sanity and consistency), but getPath + custom activity API. Oh well.
-
Vincent Pelletier authored
Just like regular indexations, fulltext indexations are subject to last-commit-wins. Which means that it is possible to reach a state where the fulltext table is persistently desynchronised from ZODB: - start fulltext indexation activity on many documents (typically: 100) - modify one of the documents being indexed - start fulltext indexation activity caused by this edit, and assume indexation only happens for this object - commit the single-object indexation (because it is very fast to retrieve fulltext data from just one document) - commit the many-objects indexation later (because it is much slower to retrieve 100 fulltext representations) As a consequence, cod emust spawn one fulltext indexation activity per document, each with the appropriate serialisation tag. Serialisation tag which must not conflict with regular indexation, so use a fixed prefix. As a consequence of having to spawn one activity per document, use a grouping method to still index by batches to amortise transaction overhead. Keep the same method_id as before for backward-compatibility (maybe dependencies on this value exist, even though it is bad practice). Rewrite SQLCatalog_deferFullTextIndexActivity so ot works as a grouping method, simplifying it in the process: - build parameter_dict with all entries, as we already know all needed keys - None is not callable, so test "not None" in just one expression - remove whitespace at end of line - use GroupedMessage API
-
Jérome Perrin authored
''.split(',') is [''] which evaluates to false ... e80b37ff was still incorrect
-
Jérome Perrin authored
This was not really backward compatible with old slapos versions not passing zserver_address_list
-
Jérome Perrin authored
To answer question in the comment: > How to inspect inside another iframe? use selectFrame (after waiting for the frame to be added in the DOM of course). Reference of selenium commands: https://web.archive.org/web/20160807232621/http://release.seleniumhq.org/selenium-core/1.0.1/reference.html#selectFrame (I'm not sure it's still on the web)
-
Jérome Perrin authored
Tests asserts that size have all languages available, so let's be compatible and just set the default language to the current selected one at site creation.
-
- 11 Sep, 2018 6 commits
-
-
Nicolas Wavrant authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This was not really backward compatible when running with old slapos, because default value was not string in this case.
-
Nicolas Wavrant authored
This step was in reality only removing the "Access Content Information" permission for Anonymous on web_site_module, which was not coherent with erp5_web, and had for consequence to make developers change it by hand when wanting to use web_site_module
-
Jérome Perrin authored
Extend test runners to use partition IP and run functional tests behind an https frontend. See nexedi/slapos!374 for the slapos part and more detailed explanations. /reviewed-on nexedi/erp5!729
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!742
-