- 05 Oct, 2019 1 commit
-
-
Arnaud Fontaine authored
* Add erp5_core_proxy_field_legacy to dependencies (because of (at least) my_password). * Rename ERP5ShortMessage.Errors module because the name is too generic for a 'Module Component'. * Fix type_class of SMSTool: This should be the name of the class only, excluding the module. * Add missing __init__.py to tests directory so that it can be migrated.
-
- 04 Oct, 2019 5 commits
-
-
Julien Muchembled authored
This is done by inheriting most of the code of ConflictFreeLog, i.e. using a doubly-linked list: - for fast iteration of the first elements, and in particular immediate access to the first element (used for creation date); - that keeps track of the history length; - that implement fast reverse iteration (although it could have been done without changing the data structure). The size of buckets is not fixed anymore to 16 items: like ConflictFreeLog, WorkflowHistoryList is also a good candidate to look at the estimated serialized size of the bucket in order to decide if elements should be added to a new one or not. Then developers won't have to care about using Pdata or not. The size is bigger than the ConflictFreeLog default, because workflow items look a lot alike and adding a few more is cheap when the ZODB compresses. No more optimized __getstate__ (except for workflow histories that have not been migrated) so BT export will be a bit more verbose. The BBB code is because of nexedi/erp5!934 /reviewed-on nexedi/erp5!941
-
Arnaud Fontaine authored
ZODB Components: Before migrating Interfaces from FS, there must be one Interface class per source file matching its name. Same as Document class: this avoids registering Interfaces at startup and just do it when using the Interface. In assuming that portal_components/XXX has a class name equals to XXX.getRference(), it is easier to: * List all existing Interfaces (for example in Portal Type Class view): getReference() on all validated 'Interface Component' in portal_components. * Lookup for an 'Interface Component': 'from erp5.component.interfaces.XXX import XXX'.
-
Arnaud Fontaine authored
ZODB Components: Properly handle addition of template_* properties in BusinessTemplate PropertySheet. On the plus side, this avoids an ugly 'except AttributeError: pass' which does not work anyway with the scenario below. Assuming the following: * template_XXX Property (accessor: getTemplateXXX) recently added to BusinessTemplate PropertySheet. * erp5_YYY sets template_A Property (erp5_YYY/bt/template_XXX.xml). This commit handles the following: 1. Stop instance with old ERP5 without template_XXX. 2. Update erp5.git. 3. Start instance. 4. Upgrade erp5_property_sheets and erp5_YYY bt5s in *one* transaction from portal_templates UI. => When upgrading erp5_YYY, BusinessTemplate.importFile() imports erp5_YYY/bt/*.xml where the list of files is based on BusinessTemplate class propertyMap(), but at this point accessors have not been re-generated yet, thus template_XXX is not returned by propertyMap() and erp5_YYY/bt/template_XXX.xml is not imported. => portal_templates/erp5_YYY new BT does not have template_XXX property set at all.
-
Ivan Tyagov authored
<family_name>-0..9 when number of nodes <= 10 <family_name>-01..09 (or n) when number of nodes > 10 In scalability tests instance keeps track of old used nodes and when nodes > 10 will pick by default sort "activity-0" which is NO longer an existing zope process. This is an ugly fix and real woraround is to have something like activities-000x schema by default
-
Arnaud Fontaine authored
This is the case with runUnitTest wrapper created by SlapOS but is not actually required as manage_addERP5Site has 'test test' as default value. This fixes: File "custom_zodb.py", line 70, in <module> sql_db = Products.ZMySQLDA.db.DB(os.environ['erp5_sql_connection_string']) File "UserDict.py", line 40, in __getitem__ raise KeyError(key) KeyError: 'erp5_sql_connection_string'
-
- 03 Oct, 2019 3 commits
-
-
Jérome Perrin authored
This module is not sorted, we cannot just do assertions based on line index. Instead we do two different approaches: - When there is only one "empty" draft transaction, we check locate the line based on the state cell and then check each cell relatively to that first xpath - After we had a second draft, we just check that we have two lines matching each cell predicate.
-
Jérome Perrin authored
Sometimes test fail we don't have any information about what the problem was. Using the same technique of turning a promise into "a function called several times until it returns true or false", we can get rejection failures in the selenium error message.
-
Jérome Perrin authored
The term (used for example on HTTPExchange_view/my_follow_up_title ) is "Follow-up". This will fix testNamingConventions failure.
-
- 02 Oct, 2019 29 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
so that user can overwrite easier in html
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
For options: ${WebPage_insertFollowUpCostEffortReport} ${WebPage_insertFollowUpCostEffortDetailReport} script's name is changed to Base_generateCostEffortReportContent and parameter is changed also
-
Ivan Tyagov authored
template for Scalability tests.
-
Georgios Dagkakis authored
It was found useful in cases, so good to have it available
-
Sebastien Robin authored
Exactly like prices and other properties, it is useful for some projects to define different descriptions depending if we are doing sales or purchases
-
Romain Courteaud authored
[erp5_core] Return 400 status code when updating a dialog
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Nicolas Wavrant authored
Also, this prevents logging the same information on every listbox load.
-
Nicolas Wavrant authored
This merge request aims to prevent programming errors by raising instead of silently doing nothing (which is a source of bugs). Currently, if an object as category property for a category "category", 2 families of setters were created : 1. The string setter, following the format ```_setCategory``` and taking a relative URL as the argument. 2. The value setter, following the format ```_setCategoryValue``` and taking an object as the argument. The issue is that developers may pass the wrong argument to one of these functions, having for consequences : 1. For case (1), if an object is passed, the code would silently do nothing : nothing is set as relation, but the code doesn't fail. This is the worst case. 2. For the second case, passing a relative URL to ```_setCategoryValue``` would "work" (in the meaning the relation is set to the correct object). This may sound like a feature, but in my opinion it is confusing given the way ERP5 developers apprehend these setters nowadays. For case 1, a test is existing that an exception is raised, but due to coding error the feature disappeared and no one noticed : https://lab.nexedi.com/Nicolas/erp5/blob/b3ed2210ed6b30390b901c8620de6eafcc27a574/product/CMFCategory/tests/testCMFCategory.py#L810-815 For case 2, compatibility code exists in the underlying function ```_setValue``` : https://lab.nexedi.com/Nicolas/erp5/blob/b3ed2210ed6b30390b901c8620de6eafcc27a574/product/ERP5Type/Base.py#L1840-1842 In this MR, the exception caused by case (1) has been restored (so now it fails loudly). Case (2) has been deprecated, in order to keep backward compatibility. I have run the tests with the ```DeprecationWarning``` raising an error instead of just a warning, and fixed the code were the setters weren't used correctly. Ideally, tests should always run with this ```DeprecationWarning``` being a real error so both cases crash loudly. This won't be part of this Merge Request. /reviewed-on nexedi/erp5!938
-
Jérome Perrin authored
This adds a new field on Test Suite Repository to configure a "gitlab connector". If this is set, then the commit from this repository will be annotated with the test status (failed or success). Gitlab uses these annotations to show that status on the merge request. At the same time, fix a few minor problems on `erp5_test_result`. /reviewed-on nexedi/erp5!924
-
Jérome Perrin authored
The way consistency check select documents to check at each run when running incremental mode, consistency seems to have issues which leads to documents not checked sometimes. I noticed two reasons: * When Zope runs with a timezone that is not `UTC`, the date comparison to find new documents compares a date in zope local timezone with a timestamp in mysql timezone. First fix is to pass a date to catalog, so that catalog convert it to the catalog timezone (it's a mistake to pass a date as string when using catalog programmatically). Second fix seem that we seem to need to configure mariadb to use `UTC` by default. * `alarm.getLastActiveProcess` does not return the latest active process when alarm is executing `activeSense` so we need to pass `include_active=True` in this case. /reviewed-on nexedi/erp5!537
-
Jérome Perrin authored
Because unlike `getFoo()`, `getProperty('foo')` does not checks the permission defined on the accessor, when a form contain a `my_foo` field, the property would be displayed to the user who can view the form, even if the user does not actually have the permission to get this property. This because getter for default value of fields uses getProperty ( [here](https://lab.nexedi.com/nexedi/erp5/blob/58d4ab8efef748f522b3eaaecba3dc1133c99e72/product/ERP5Form/Form.py#L275) ). These changes modify behavior of `getProperty`, so that it enforces read permission security of properties and raise when user does not have permission to access properties. Some notes about implementation: * `getProperty` now becomes a bit slower, but it was incorrect before, so I guess it's inevitable. * some efforts have been made to keep the impact on performance minimal. This uses the same approach of in `edit` of computing the set of restricted properties and using `guarded_getattr` only on these properties and using `getattr` on non-restricted properties. The computation of this set was moved to dynamic class generation time and as a result, `edit` becomes a bit faster. * the `expectedFailure` part of `test_PropertySheetSecurityOnAccessors` was moved to another test, but I'm not even sure we want to support this (read-protecting properties with default write permission) as, to me, such configuration does not make much sense. * new performance tests were added. I don't know what to use as min/max values so I just used something that should pass. * implementation for `getProperty('*_list')` was changed a lot, I have no idea why this was getting the method on the class and passing self as first argument. Now it we just get method on the instance, like we do for single properties. /reviewed-on nexedi/erp5!181
-
- 01 Oct, 2019 2 commits
-
-
Ivan Tyagov authored
-
Ivan Tyagov authored
all repository list which will cause a mismatch between test suite class location and repository. /reviewed-on nexedi/erp5!945
-