An error occurred fetching the project authors.
- 05 Jul, 2017 7 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This was an error reported by pylint. This changes fixes the behavior, but should have been the original behavior;
-
Jérome Perrin authored
-
Jérome Perrin authored
to InternalInvoiceTransaction_getAuthenticatedUserSection. It was a violation of our naming conventions.
-
Jérome Perrin authored
This was a violation to our naming conventions
-
Jérome Perrin authored
-
- 04 Jul, 2017 5 commits
-
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!313
-
Cédric Le Ninivin authored
-
Cédric Le Ninivin authored
-
Cédric Le Ninivin authored
-
Sven Franck authored
Revert "erp5_officejs_afs_directory: add missing allow cross domain header" This reverts commit 2674afaa. Revert "erp5_officejs_afs_directory: rewrite custom storages and automate openhub data retrieval via proxy" This reverts commit f74f420e.
-
- 03 Jul, 2017 10 commits
-
-
Sven Franck authored
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Pelletier authored
Such default parameters prevent even entering the module once the document count is large enough.
-
Vincent Pelletier authored
Do log it, but do not let it propagate.
-
Jérome Perrin authored
Since early days of @arnau work on ERP5 components, we have pylint integrated as a way to check the code in components and in python scripts but nothing prevents us from commiting code with lint errors, leaving the problem for the next developer. For this, I extended [`CodingStyleTestCase`](https://lab.nexedi.com/nexedi/erp5/blob/88e4b34ff67aa07447f81c8af836feba607843e8/product/ERP5Type/tests/CodingStyleTestCase.py) that was introduced for very similar purpose so that it also use our tool to check python code. This way, we can have failing tests when the code do not pass pylint. What's still not good is that if we want a business template to be tested, we have to explicitly add a test for this business template, but it's also the case for all our "static" tests (naming conventions, HTML validation etc). A missing feature was that there was no way to get an overview of all the reported problems on a business template. For this, I added a report action on business template that uses the same code to display errors in all *python* code from a business template: ![ERP5_pylint_business_template](/uploads/13613199227884f0340b8f1c40ca4418/ERP5_pylint_business_template.png) ( the lines have direct links to edit python code ) Because `testERP5WebCodingStyle` was already here checking `erp5_web` (well not really because it was no longer using `CodingStyleTestCase` correctly) , I fixed all problems reported by pylint in erp5_web. In reality it only took a few minutes to do this. PS: I don't know exactly how we could integrate javascript linter in all this. We have a [`test_javascript_lint`](https://lab.nexedi.com/nexedi/erp5/blob/master/product/ERP5/tests/testXHTML.py#L171), but it does not test much of the code written recently because it only checks portal skins. @romain and @vincentB maybe have plans for this. Anyway, it's out of the scope of this. /cc @kazuhiko @vpelletier @tc /reviewed-on nexedi/erp5!308
-
- 30 Jun, 2017 1 commit
-
-
Sven Franck authored
-
- 29 Jun, 2017 13 commits
-
-
Kazuhiko Shiozaki authored
erp5_mysql_innodb_catalog: add safety LIMIT in z_getitem_by_path and z_getitem_by_uid to avoid fetching all rows in case of empty argument.
-
Kazuhiko Shiozaki authored
otherwise Localizer will not work in grouped activity.
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
-
Jérome Perrin authored
business template metadata was not commited
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This replaces ERP5Site_checkPythonScriptsWithPyflakes that I guess nobody was using
-
Jérome Perrin authored
CodingStyleTestCase tests by default the last business template returned in getBusinessTemplateList, but getBusinessTemplateList returned value changed overtime and this test did not really test erp5_web Also name include "ERP5 Web" in test class name, as it tests ERP5 Web.
-
Jérome Perrin authored
This is for catalog brain displayed in Listbox.
-
Jérome Perrin authored
It exists in portal_types
-
Jérome Perrin authored
-
Jérome Perrin authored
* explain how to use * remove useless getTitle method * fix indentation
-
- 28 Jun, 2017 4 commits
-
-
Cédric Le Ninivin authored
-
Tomáš Peterka authored
-
Tomáš Peterka authored
[erp5_hal_json_style] Fix ordering of annotations in the test to set the right skin at the beginning
-
Tomáš Peterka authored
-