1. 03 Jul, 2020 4 commits
    • Jérome Perrin's avatar
      base: don't allow selecting draft currencies by default · 3c0c9da6
      Jérome Perrin authored
      The initial intention was to "disallow invalidated", without forcing users to
      validate everything, but it was probably a mistake, if users don't need to
      validate then validation workflow would be a bit meaningless.
      
      This is made after an incident where a user mistakenly cloned a validated
      currency and the cloned currency was available everywhere in the system.
      
      Change to not return draft currencies by default and also change so that all
      items are tuple, for consistency. That should have no impact and is a bit
      easier for the test.
      
      Also adjust accounting_ui_test, we need to validate currencies for the tests
      and clear cache if we validated some (but we don't need to clear cache if we
      validate accounts, because account caches is more clever and does not need to
      clear all cache)
      3c0c9da6
    • Jérome Perrin's avatar
      core: fix pylint warning in WebDAVSupport · 4e1b5f93
      Jérome Perrin authored
      Unused aq_base imported from Acquisition (unused-import)
      4e1b5f93
    • Rafael Monnerat's avatar
      ERP5Security: GoogleLogin some properties don't always come · 712d7cf8
      Rafael Monnerat authored
      See merge request !1176
      712d7cf8
    • Arnaud Fontaine's avatar
      testWebDAVSupport: Fix failures due to 21becf4c. · b72eff1a
      Arnaud Fontaine authored
      WebDAVSupport module was migrated to ZODB Components in 21becf4c. This module
      contains a monkey patch (5c7d50d5) on webdav.NullResource.PUT which should
      really be in Products.ERP5Type.patches and was not applied anymore since the
      migration.
      b72eff1a
  2. 02 Jul, 2020 18 commits
  3. 01 Jul, 2020 1 commit
  4. 30 Jun, 2020 4 commits
    • Jérome Perrin's avatar
      SecurityTestCase: generate assertUserCanNot... methods · 1266c706
      Jérome Perrin authored
      the "failIf..." naming scheme is deprecated in unittest, we should at
      least have new-style named methods
      1266c706
    • Jérome Perrin's avatar
      trade: Display tax lines in order printout · b7b5f217
      Jérome Perrin authored
      So far, simulated tax is not included in printed Orders. This allow to include expected tax in vat_list for printout.
      
      This is done using `getPreferredTaxUseList` which is probably wrong and will hopefully be rewritten using more modern technologies (html not odt) and to use base amount, but this allows to make order printout show tax lines again.
      
      See merge request nexedi/erp5!1168
      b7b5f217
    • Jérome Perrin's avatar
      renderjs: update translation data in post-upgrade · a39b74c2
      Jérome Perrin authored
      Firstly, rework a bit the action to create translation data, the action no longer allow choosing the translation data script to update, but uses the one referenced in the translation gadget html.
      
      In post upgrade, compare the actual content of the translation data script with the expected content, calculated from web site languages, data-i18n attributes from referenced pages and Localizer messages.
      
      This makes the requirement that web sites with different configurations for translations need to use different translation gadget stronger, when it's not met post upgrade will always report consistency issues. To address this, modify existing web sites so that they all use different translation gadgets - or at least don't use translation gadget explicitly. 
      
      This was made by:
       - all web sites by default do not have a translation gadget
       - smart_assistant use a dedicated translation gadget, to confirm that using a different translation gadget is possible with an officejs web site, where the translation gadget is defined in the "app" web section.
       - officejs_support_request_ui uses a dedicated translation gadget, because we need this for a customer project and for ourselves.
       - other web sites do not support translation by default, but enabling would be easy: 
          - set the allowed languages on web site
          - create an empty web script ( `{website}_translation_data.js` )
          - create a translation gadget web page ( `{website}_translation.html` ) using same content as `gadget_translation.html`, except that the translation data script should be the one created above ( `{website}_translation_data.js` )
          - configure the web site to use translation gadget in layout properties. In the case of an OfficeJS web site, this should not be set on the web site but on the main web section
          - use "Update Translation Data" action on web site or run post-upgrade step of upgrader.
      
      This revealed problems (page does not load with javascript error) when using different translation gadgets, that were addressed by not pre-loading the default translation gadget.
      
      See merge request nexedi/erp5!1151
      a39b74c2
    • Jérome Perrin's avatar
      Make ERP5JS login pages look like ERP5JS Dialogs · 1833f952
      Jérome Perrin authored
      ![login](/uploads/d270b602f784466dcc8d0806ec0ab9e1/image.png)
      
      ![recover](/uploads/da5bca427e6053a4724a4f7171db71db/image.png)
      
      ![reset password](/uploads/27e3519dfaf96cd66ce3adf9d6184ba8/image.png)
      
      
      See merge request nexedi/erp5!1165
      1833f952
  5. 29 Jun, 2020 9 commits
  6. 26 Jun, 2020 2 commits
  7. 25 Jun, 2020 2 commits
    • Arnaud Fontaine's avatar
      ZODB Components: Fix pylint warning. · c8e12a94
      Arnaud Fontaine authored
      W: Dangerous default value _MARKER (__builtin__.list) as argument (dangerous-default-value)
      c8e12a94
    • Nicolas Wavrant's avatar
      erp5_trade: move the composition cache in BusinessProcess.py · e5587493
      Nicolas Wavrant authored
      Since BusinessProcess.py was moved to portal_components, the cache in mixin/composition.py,
      which was kept at the level of the zope process, was causing issue when portal_components
      was reset : the classes kept in __class_cache would not get resetted, and later calls
      to asComposedDocument would reuse them. In consequence, these classes would kept pointers
      to objects in the old class BusinessProcess, causing bugs as these objects would have
      been cleaned by the reset.
      
      The first intuition was to remove this cache, unfortunately the reason of this introduction
      (fixing a memory leak) is still valid nowadays, so I've decided to move this cache within
      BusinessProcess, as it has the advantage of emptying it whenever portal_components is resetted.
      
      For more information of the bug mentionned above, and the trials about removing the cache can
      be found in the discussion of this MR :
      nexedi/erp5!1032
      e5587493