1. 19 Dec, 2019 6 commits
    • Jérome Perrin's avatar
      Make erp5_core pass coding style test · 45f71807
      Jérome Perrin authored
      /reviewed-on nexedi/erp5!996
      45f71807
    • Jérome Perrin's avatar
      core: prevent calling catalog with an empty list · d9f07b5b
      Jérome Perrin authored
      Folder_getDeleteObjectList could do an extra paranaoïa check that the
      caller did not pass an empty list of uids, because this would cause the
      script to iterate on the full catalog table.
      d9f07b5b
    • Jérome Perrin's avatar
      core: fix Folder_cut to check relations of sub-objects · 7ac21fb5
      Jérome Perrin authored
      We now have getRelationCountForDeletion API for this.
      7ac21fb5
    • Jérome Perrin's avatar
      core: fixes for pylint · 31e71335
      Jérome Perrin authored
      The general approach is:
      - replace deprecated lambdas with list comprehensions
      - remove unused variables/imports
      - replace dangerous arguments [] with ()
      - replace dangerous arguments {} with None and "if None -> {}"
      - replace builtin names with something similar
      
      Now that all problems reported by pylint are fixed, enable coding style
      test.
      31e71335
    • Jérome Perrin's avatar
      code_mirror: move editor field's inline css to separate file · ef456975
      Jérome Perrin authored
      This was not valid HTML5:
      
        AssertionError: Using nu validator to parse the view "SQLMethod_view" (from erp5_core bt) with warnings displayed :
        Error: line 782 column 23 : Element “style” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.): </script>
        <style type="text/css">
          .cm
        Error: line 822 column 23 : Element “style” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.): script>
      
        <style type="text/css">
          .max
      ef456975
    • Jérome Perrin's avatar
      administration: fix catalog table scan in Item_checkTrackingList · c1cb1cc3
      Jérome Perrin authored
      This fix a regression from 920655a2 : when item has no tracking, uid was
      passed an empty list and this fetched all catalog.
      Also call getObject explicitly only once instead of having it called
      implicitly twice.
      c1cb1cc3
  2. 18 Dec, 2019 5 commits
  3. 16 Dec, 2019 5 commits
  4. 13 Dec, 2019 7 commits
  5. 12 Dec, 2019 5 commits
  6. 11 Dec, 2019 1 commit
    • Jérome Perrin's avatar
      CodingStyleTest: run testXHTML for each business template · 7988bc67
      Jérome Perrin authored
       - run `testXHTML` on business templates "one by one"
       - fix all the problems with the currently tested business templates
       - because `erp5_ingestion` was containing some tests skin folder depending on other business templates and because I did not want to add dependencies to `erp5_ingestion` I moved the tests in `erp5_ingestion_test`.
      
      /reviewed-on nexedi/erp5!989
      7988bc67
  7. 10 Dec, 2019 3 commits
  8. 06 Dec, 2019 4 commits
  9. 03 Dec, 2019 4 commits