This was working only with Organisations

The only check with accounting transactions regarding bank account
was that the bank account is not invalidated. This makes the
constraint more strict by checking that the bank account belongs to
the corresponding entity and also that the bank account is validated.

A few tests needed to be updated to validate the bank accounts. Also
a legacy sequence test has been removed because it is now covered by
normal tests.

The parameter is still named `organisation` for "API stability", but
this parameter can be a person.

This was already used by the fields on accounting transaction for
source/destination_payment and more or less working already, except
for the case where the person had a subordination to an organisation
member of the group, in that case instead of showing the bank accounts
from the person this was showing the bank accounts from the
organisation

On a transaction without section / mirror section, on the profile tab
all accouts where displayed

drop skip_invalidated_bank_accounts option, we are now using
base_category instead.

erp5_accounting, erp5_payment_mean: display currently selected Bank Account even if it is invalidated.

no need to validate them in the test

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type

see https://github.com/zopefoundation/Products.ZMySQLDA/commit/c31affe2edfa0fdd04b3bba5907e00ebb8c80ed2

See nexedi/erp5@0c2dd107

Coding crime.

See nexedi/erp5@cbb3b35b

`python` command doesn't exist anymore in most recent distribution and
our PASS (theia), but python3 has been available for years now.

https://lab.nexedi.com/nexedi/erp5/blob/bb7d107124e96a6176f56226d3093d8845c3949d/product/Formulator/Form.py#L228

context is actually a web section

and fix some missing cache

automaticLayout can not be used with firefox 68 (the browser from test
nodes) because it lacks support for ResizeObserver

triggered manually with "Format Document" of "Format Selection"
actions

This enables usage of @ in quick pick to search for symbols and make
sticky scroll show the current context

   Probably there are missing files but it is a start.

With tweaks to support firefox 68 from test nodes:
 - build with babel, see monaco-editor-erp5@cf10f2d5
 - special handling of ResizeObserver that does not exist in Firefox
   68: it is used only for automaticLayout, which is not strictly
   needed. So this feature will not work for firefox 68.

Enable sticky scroll

Set caching manager to must_revalidate_http_cache

This is different from the total of durations of test result lines
because they are executed in parralel on different testnodes. The
actual duration is just the difference between start and stop, so
that we don't have to calculate.

This makes it easier to understand the duration in minutes and hours

There is no good reason to prevent editing in cancelled state and
it can be needed, for example to remove a cancelled payment
transaction from a payment transaction group.

The add-hoc assertin filter:

--

from typing import List

import lib2to3

from lib2to3.fixer_base import BaseFix
from lib2to3.fixer_util import Comma, Name

class FixAssertIn(BaseFix):

  PATTERN = """
      power< any+ trailer< '.' meth=("assertTrue" | "assertFalse")>
      trailer< '('
        comparison< (needle=any ( comp_op<'not' 'in'> | 'in' ) haystack=any) >
      ')' > >
  """

  def transform(self, node: lib2to3.pytree.Node,
                results: List[lib2to3.pytree.Base]):

    needle = results['needle']
    haystack = results['haystack']
    meth = results["meth"][0]

    method_map = {True: 'assertIn', False: 'assertNotIn'}
    method_in = meth.value == 'assertTrue'
    if 'not' in str(needle.parent.children[1]):
      method_in = not method_in
    meth.replace(Name(method_map[method_in], prefix=meth.prefix))

    needle.parent.children = [needle, Comma(), haystack]

so that we can run 2to3.fix_assert

this code was latin 1, causing issues for refactoring scripts

Form.__call__ replaces page template call, so it is also responsible
to set the content type in response.

With Page Templates, ZopePageTemplate._exec (called by
Shared.DC.Scripts.Bindings.__call__ and _bindAndExec) sets the
response content type and calls pt_render. Form.__call__ also calls
pt_render, so to behave like page template, it should also sets the
response content type.

In erp5_xhtml_style, we don't notice this, because global_definitions
contains a setHeader call to set content type to html.

Check that it correctly includes the web page and sets the content
type header.

it would be good to rewrite this in a page template