- 02 Feb, 2016 2 commits
-
-
Kamil Trzcinski authored
Add the `read_build` ability if user is anonymous or guest and allow_guest_to_access_builds is enabled.
-
Kamil Trzcinski authored
This MR simplifies CI permission model: - read_build: allows to read a list of builds, artifacts and trace - update_build: allows to cancel and retry builds - create_build: allows to create builds from gitlab-ci.yml (not yet implemented) - admin_build: allows to manage triggers, runners and variables - read_commit_status: allows to read a list of commit statuses (including the overall of builds) - create_commit_status: allows to create a new commit status using API Remove all extra methods to manage permission. Made all controllers to use explicitly the new permissions.
-
- 01 Feb, 2016 11 commits
-
-
Robert Speicher authored
Allow manual resize of js-autosize textareas First, the autosize library was being too controlling and removed the `resize` property from any elements to which it was attached, removing the drag handle. We've disabled this behavior in the vendored library and added a spec to prevent a regression during an upgrade. Second, we detect (as best we can) when the user manually resizes an autosize textarea, and then remove the autosize behavior from it and increase its max-height. This should allow for the best of both worlds. Closes #12832 See merge request !2653
-
Robert Speicher authored
First, the autosize library was being too controlling and removed the `resize` property from any elements to which it was attached, removing the drag handle. Second, we detect when the user manually resizes an autosize textarea, and then remove the autosize behavior from it and increase its max-height. This should allow for the best of both worlds. Closes #12832
-
Robert Speicher authored
[ci skip]
-
Robert Speicher authored
Optimize fetching issues closed by a merge request Related issue: #12419 See merge request !2625
-
Dmitriy Zaporozhets authored
Render sanitized SVG images Originally opened at !637 by @stanhu. Closes https://github.com/gitlabhq/gitlabhq/issues/9265 ![Screen_Shot_2016-02-01_at_17.04.01](/uploads/8e5de906698493e127dcdc475da9aaef/Screen_Shot_2016-02-01_at_17.04.01.png) See merge request !2667
-
Stan Hu authored
Closes https://github.com/gitlabhq/gitlabhq/issues/9265
-
Dmitriy Zaporozhets authored
Link to Thoughtbot review guidelines. See merge request !2658
-
Yorick Peterse authored
Instead of running ClosingIssueExtractor for every commit in a merge request we can gather all the commit messages (and the merge request description), concatenate all this together and then run ClosingIssueExtractor only once. The result of this is that MergeRequest#closes_issues is now between 3.5x and 4x faster than the old setup. Using a merge request with 10 commits (each referencing a number of issues to close) this reduced the call duration from around 200 milliseconds to around 50 milliseconds. As a result of these changes the Jira related tests for MergeRequest#closes_issues have been removed. These tests stubbed Commit#closes_issues meaning that the only code that was really tested was the call to Array#uniq to filter out duplicate issues. As this code is no longer used (nor present) the corresponding tests were removed. Related: gitlab-org/gitlab-ce#12419
-
Robert Speicher authored
Make "Two-factor" casing consistent throughout the application See merge request !2662
-
Robert Speicher authored
-
Robert Speicher authored
[ci skip]
-
- 31 Jan, 2016 2 commits
-
-
Achilleas Pipinellis authored
Improve GitLab flow documentation regarding the WIP merge requests See merge request !2647
-
Robert Speicher authored
Mark inline difference between old and new paths when a file is renamed See merge request !2652
-
- 30 Jan, 2016 8 commits
-
-
Sytse Sijbrandij authored
-
Douwe Maan authored
Increase the minimum length for commit SHA matching to 7 This is the git default and will help to prevent false positive matches. Closes #12706 See merge request !2655
-
Douwe Maan authored
-
Douwe Maan authored
-
Dmitriy Zaporozhets authored
Cache BroadcastMessage.current. Fixes #12770 See merge request !2633
-
Dmitriy Zaporozhets authored
-
Douwe Maan authored
Warn admin of granting admin rights during OAuth Fixes #3951 Warning style the same as the warning a user sees on a archived project. ![Screenshot_from_2016-01-25_20-06-33](/uploads/42e6a218b963311fd20c0b7c87c8cf4f/Screenshot_from_2016-01-25_20-06-33.png) See merge request !2601
-
Robert Speicher authored
This is the git default and will help to prevent false positive matches. Closes #12706
-
- 29 Jan, 2016 17 commits
-
-
Josh Frye authored
-
Josh Frye authored
-
Douwe Maan authored
-
Achilleas Pipinellis authored
Fixed typo for PRIVATE-TOKEN header Was PRIVATE_TOKEN but should be PRIVATE-TOKEN. Underscore vs. kebab-case. See merge request !2624
-
Robert Speicher authored
add missing `RAILS_ENV=production` bit to bundle command [ci skip] See merge request !2626
-
Douglas Barbosa Alexandre authored
Fix "old version" warning when viewing wiki page's latest version via version_id in URL Fixes #12712 See merge request !2627
-
Drew Blessing authored
Increase LFS objects size column Fixes #12745 Increases the `size` column integer limit to an 8-byte integer. This allows for a max value of `9223372036854775807` which is 9,223,372,036 GB. That should do it
😃 I tested this by first reproducing the error (push a file larger than 2.1 GB). The error was: ``` RangeError (3145728000 is out of range for ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Integer with limit 4): lib/gitlab/lfs/response.rb:232:in `store_file' lib/gitlab/lfs/response.rb:170:in `render_lfs_upload_ok' lib/gitlab/lfs/response.rb:51:in `block in render_storage_upload_store_response' lib/gitlab/lfs/response.rb:204:in `render_response_to_push' lib/gitlab/lfs/response.rb:50:in `render_storage_upload_store_response' lib/gitlab/lfs/router.rb:76:in `put_response' lib/gitlab/lfs/router.rb:20:in `try_call' lib/gitlab/backend/grack_auth.rb:41:in `call' lib/gitlab/backend/grack_auth.rb:18:in `call_with_kerberos_support' lib/gitlab/backend/grack_auth.rb:8:in `call' ``` Then I ran this migration and pushed the file again. It uploaded successfully. See merge request !2644 -
Douglas Barbosa Alexandre authored
-
Jacob Schatz authored
Auto-focus emoji award search field ![emoji-search-focus](/uploads/7cd0448e00ced19d3cf1c4fdd141c74f/emoji-search-focus.gif) Closes #12621 cc. @jschatz1 See merge request !2650
-
Drew Blessing authored
-
Josh Frye authored
-
Josh Frye authored
-
Dmitriy Zaporozhets authored
Background process note logic for #3948 Quick and dirty way to get *most* of the note processing out of band and into the background. Seeing some pretty nice speed bumps. Keep in mind that doing this in process results in slower and slower responses as more notes are added and more participants exist. ``` without background processing Completed 200 OK in 627ms (Views: 0.5ms | ActiveRecord: 32.3ms) Completed 200 OK in 478ms (Views: 0.8ms | ActiveRecord: 28.3ms) Completed 200 OK in 1107ms (Views: 0.6ms | ActiveRecord: 36.6ms) with background processing Completed 200 OK in 108ms (Views: 0.6ms | ActiveRecord: 4.7ms) Completed 200 OK in 78ms (Views: 0.5ms | ActiveRecord: 4.5ms) Completed 200 OK in 164ms (Views: 0.5ms | ActiveRecord: 8.3ms) ``` As you can see, speeds are consistent when doing the harder work out of process. I'm not sure the number of sql queries we're saving, but based on the logs alone it's a pretty good amount. @dzaporozhets @yorickpeterse I would love some input on this. See merge request !2631
-
Dmitriy Zaporozhets authored
Partially revert "Add IP check against DNSBLs at account sign-up" This partially reverts 6a5cd3ca - we keep the migration and add a new migration that reverts it in order to keep migration history intact. See merge request !2643
-
Phil Hughes authored
-
Phil Hughes authored
Closes #12621
-
Dmitriy Zaporozhets authored
Prevent transient Capybara timeouts during feature tests The problem occurred because asset compilation takes a long time, so when the asset cache didn't exist and the first test ran, it would often (randomly) time out during the generation before the actual test even had a chance to run. Now we check if the cache exists before the suite runs, and if not, we manually fire a request to the root URL in order to generate it. This should allow subsequent tests to use the cached assets. See merge request !2646
-