Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
131c7079
Commit
131c7079
authored
Jan 25, 2012
by
Nadeem Vawda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #13862: Relax zlib version test to avoid spurious failures.
parent
9b727eca
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
6 deletions
+9
-6
Lib/test/test_zlib.py
Lib/test/test_zlib.py
+6
-6
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/test/test_zlib.py
View file @
131c7079
...
...
@@ -16,12 +16,12 @@ except ImportError:
class
VersionTestCase
(
unittest
.
TestCase
):
def
test_library_version
(
self
):
#
On the build system, ZLIB_RUNTIME_VERSION should match ZLIB_VERSION.
#
ZLIB_RUNTIME_VERSION is the actual library version while ZLIB_VERSION
#
is the version from the header file. On the build system, the headers
#
should match with the library exactly. At runtime, only the first
#
digit is required to match
.
self
.
assertEqual
(
zlib
.
ZLIB_RUNTIME_VERSION
,
zlib
.
ZLIB_VERSION
)
#
Test that the major version of the actual library in use matches the
#
major version that we were compiled against. We can't guarantee that
#
the minor versions will match (even on the machine on which the module
#
was compiled), and the API is stable between minor versions, so
#
testing only the major verions avoids spurious failures
.
self
.
assertEqual
(
zlib
.
ZLIB_RUNTIME_VERSION
[
0
],
zlib
.
ZLIB_VERSION
[
0
]
)
class
ChecksumTestCase
(
unittest
.
TestCase
):
...
...
Misc/NEWS
View file @
131c7079
...
...
@@ -461,6 +461,9 @@ Core and Builtins
Library
-------
-
Issue
#
13862
:
Fix
spurious
failure
in
test_zlib
due
to
runtime
/
compile
time
minor
versions
not
matching
.
-
Issue
#
12804
:
Fix
test_socket
and
test_urllib2net
failures
when
running
tests
on
a
system
without
internet
access
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment