Commit 131c7079 authored by Nadeem Vawda's avatar Nadeem Vawda

Issue #13862: Relax zlib version test to avoid spurious failures.

parent 9b727eca
...@@ -16,12 +16,12 @@ except ImportError: ...@@ -16,12 +16,12 @@ except ImportError:
class VersionTestCase(unittest.TestCase): class VersionTestCase(unittest.TestCase):
def test_library_version(self): def test_library_version(self):
# On the build system, ZLIB_RUNTIME_VERSION should match ZLIB_VERSION. # Test that the major version of the actual library in use matches the
# ZLIB_RUNTIME_VERSION is the actual library version while ZLIB_VERSION # major version that we were compiled against. We can't guarantee that
# is the version from the header file. On the build system, the headers # the minor versions will match (even on the machine on which the module
# should match with the library exactly. At runtime, only the first # was compiled), and the API is stable between minor versions, so
# digit is required to match. # testing only the major verions avoids spurious failures.
self.assertEqual(zlib.ZLIB_RUNTIME_VERSION, zlib.ZLIB_VERSION) self.assertEqual(zlib.ZLIB_RUNTIME_VERSION[0], zlib.ZLIB_VERSION[0])
class ChecksumTestCase(unittest.TestCase): class ChecksumTestCase(unittest.TestCase):
......
...@@ -461,6 +461,9 @@ Core and Builtins ...@@ -461,6 +461,9 @@ Core and Builtins
Library Library
------- -------
- Issue #13862: Fix spurious failure in test_zlib due to runtime/compile time
minor versions not matching.
- Issue #12804: Fix test_socket and test_urllib2net failures when running tests - Issue #12804: Fix test_socket and test_urllib2net failures when running tests
on a system without internet access. on a system without internet access.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment