Commit 3058b7d8 authored by Pablo Galindo's avatar Pablo Galindo Committed by GitHub

bpo-33613: Fix test_semaphore_tracker signal tests when using -Werror (GH-9778)

Tests involving sending signals to the semaphore_tracker will not fail anymore due to
the fact that running the test suite with -Werror propagates warnings as errors.

Fix a missing assertion when the semaphore_tracker is expected to die.
parent d0bb5d73
...@@ -4548,7 +4548,8 @@ class TestSemaphoreTracker(unittest.TestCase): ...@@ -4548,7 +4548,8 @@ class TestSemaphoreTracker(unittest.TestCase):
if pid is not None: if pid is not None:
os.kill(pid, signal.SIGKILL) os.kill(pid, signal.SIGKILL)
os.waitpid(pid, 0) os.waitpid(pid, 0)
with warnings.catch_warnings(record=True) as all_warn: with warnings.catch_warnings():
warnings.simplefilter("ignore")
_semaphore_tracker.ensure_running() _semaphore_tracker.ensure_running()
pid = _semaphore_tracker._pid pid = _semaphore_tracker._pid
...@@ -4557,6 +4558,7 @@ class TestSemaphoreTracker(unittest.TestCase): ...@@ -4557,6 +4558,7 @@ class TestSemaphoreTracker(unittest.TestCase):
ctx = multiprocessing.get_context("spawn") ctx = multiprocessing.get_context("spawn")
with warnings.catch_warnings(record=True) as all_warn: with warnings.catch_warnings(record=True) as all_warn:
warnings.simplefilter("always")
sem = ctx.Semaphore() sem = ctx.Semaphore()
sem.acquire() sem.acquire()
sem.release() sem.release()
...@@ -4569,7 +4571,7 @@ class TestSemaphoreTracker(unittest.TestCase): ...@@ -4569,7 +4571,7 @@ class TestSemaphoreTracker(unittest.TestCase):
if should_die: if should_die:
self.assertEqual(len(all_warn), 1) self.assertEqual(len(all_warn), 1)
the_warn = all_warn[0] the_warn = all_warn[0]
issubclass(the_warn.category, UserWarning) self.assertTrue(issubclass(the_warn.category, UserWarning))
self.assertTrue("semaphore_tracker: process died" self.assertTrue("semaphore_tracker: process died"
in str(the_warn.message)) in str(the_warn.message))
else: else:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment