1. 14 Dec, 2018 5 commits
  2. 13 Dec, 2018 1 commit
  3. 12 Dec, 2018 5 commits
  4. 11 Dec, 2018 12 commits
  5. 10 Dec, 2018 10 commits
  6. 09 Dec, 2018 5 commits
  7. 08 Dec, 2018 2 commits
    • Zackery Spytz's avatar
      bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033) · 99d56b53
      Zackery Spytz authored
      In _localemodule.c and selectmodule.c, remove dead code that would
      cause double decrefs if run.
      
      In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
      where a new list is populated and there is no possibility of an error.
      
      In addition, check if the list changed size in the loop in array_array_fromlist().
      99d56b53
    • Mario Corchero's avatar
      bpo-35330: Don't call the wrapped object if `side_effect` is set (GH10973) · f05df0a4
      Mario Corchero authored
      * tests: Further validate `wraps` functionality in `unittest.mock.Mock`
      
      Add more tests to validate how `wraps` interacts with other features of
      mocks.
      
      * Don't call the wrapped object if `side_effect` is set
      
      When a object is wrapped using `Mock(wraps=...)`, if an user sets a
      `side_effect` in one of their methods, return the value of `side_effect`
      and don't call the original object.
      
      * Refactor what to be called on `mock_call`
      
      When a `Mock` is called, it should return looking up in the following
      order: `side_effect`, `return_value`, `wraps`. If any of the first two
      return `mock.DEFAULT`, lookup in the next option.
      
      It makes no sense to check for `wraps` returning default, as it is
      supposed to be the original implementation and there is nothing to
      fallback to.
      f05df0a4