1. 31 Jul, 2004 2 commits
    • Tim Peters's avatar
      Armin asked for a list_ass_slice review in his checkin, so here's the · 8d9eb10c
      Tim Peters authored
      result.
      
      list_resize():  Document the intent.  Code is increasingly relying on
      subtle aspects of its behavior, and they deserve to be spelled out.
      
      list_ass_slice():  A bit more simplification, by giving it a common
      error exit and initializing more values.
      
      Be clearer in comments about what "size" means (# of elements?  # of
      bytes?).
      
      While the number of elements in a list slice must fit in an int, there's
      no guarantee that the number of bytes occupied by the slice will.  That
      malloc() and memmove() take size_t arguments is a hint about that <wink>.
      So changed to use size_t where appropriate.
      
      ihigh - ilow should always be >= 0, but we never asserted that.  We do
      now.
      
      The loop decref'ing the recycled slice had a subtle insecurity:  C doesn't
      guarantee that a pointer one slot *before* an array will compare "less
      than" to a pointer within the array (it does guarantee that a pointer
      one beyond the end of the array compares as expected).  This was actually
      an issue in KSR's C implementation, so isn't purely theoretical.  Python
      probably has other "go backwards" loops with a similar glitch.
      list_clear() is OK (it marches an integer backwards, not a pointer).
      8d9eb10c
    • Tim Peters's avatar
      Repair typo in docstring. · bcc95cb7
      Tim Peters authored
      bcc95cb7
  2. 30 Jul, 2004 6 commits
  3. 29 Jul, 2004 12 commits
  4. 28 Jul, 2004 10 commits
  5. 27 Jul, 2004 8 commits
  6. 26 Jul, 2004 2 commits