• Russ Cox's avatar
    [release-branch.go1.4] runtime: fix atomic operations on non-heap addresses · 791fec05
    Russ Cox authored
    ««« CL 179030043 / e4ab8f908aac
    runtime: fix atomic operations on non-heap addresses
    Race detector runtime does not tolerate operations on addresses
    that was not previously declared with __tsan_map_shadow
    (namely, data, bss and heap). The corresponding address
    checks for atomic operations were removed in
    https://golang.org/cl/111310044
    Restore these checks.
    It's tricker than just not calling into race runtime,
    because it is the race runtime that makes the atomic
    operations themselves (if we do not call into race runtime
    we skip the atomic operation itself as well). So instead we call
    __tsan_go_ignore_sync_start/end around the atomic operation.
    This forces race runtime to skip all other processing
    except than doing the atomic operation itself.
    Fixes #9136.
    
    LGTM=rsc
    R=rsc
    CC=golang-codereviews
    https://golang.org/cl/179030043
    
    »»»
    
    TBR=dvyukov
    CC=golang-codereviews
    https://golang.org/cl/180030043
    791fec05
race.c 8.78 KB