• Brad Fitzpatrick's avatar
    cmd/dist: fix computation of test timeout · 8aa316c1
    Brad Fitzpatrick authored
    When dist test was updated to run "go test" with multiple package
    arguments at once, merging the logical test units into one execution,
    the hack to give cmd/go twice as much time wasn't updated.
    
    What was happening (even in the all.bash case) was that we were
    merging together, say, "cmd/go" and "bytes", and because bar was
    lexically earlier, the timeout calculation was based on package "byte",
    even though we were actually running, say: "go test bytes cmd/go".
    
    This explains why x/build/cmd/release was often flaky with its
    all.bash, since cmd/go can't really finish in 3 minutes reliably
    unless it's running by itself. If it has any competition, it runs
    over.
    
    Change-Id: I875c8c9e65940ce0ceff48215740dfadfaa89d3f
    Reviewed-on: https://go-review.googlesource.com/111395
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarAndrew Bonventre <andybons@golang.org>
    8aa316c1
test.go 39.1 KB