• H. Nikolaus Schaller's avatar
    DTS: ARM: gta04: remove legacy spi-cs-high to make display work again · 07af7810
    H. Nikolaus Schaller authored
    This reverts
    
    commit f1f028ff ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")
    
    which had to be intruduced after
    
    commit 6953c57a ("gpio: of: Handle SPI chipselect legacy bindings")
    
    broke the GTA04 display. This contradicted the data sheet but was the only
    way to get it as an spi client operational again.
    
    The panel data sheet defines the chip-select to be active low.
    
    Now, with the arrival of
    
    commit 766c6b63 ("spi: fix client driver breakages when using GPIO descriptors")
    
    the logic of interaction between spi-cs-high and the gpio descriptor flags
    has been changed a second time, making the display broken again. So we have
    to remove the original fix which in retrospect was a workaround of a bug in
    the spi subsystem and not a feature of the panel or bug in the device tree.
    
    With this fix the device tree is back in sync with the data sheet and
    spi subsystem code.
    
    Fixes: 766c6b63 ("spi: fix client driver breakages when using GPIO descriptors")
    CC: stable@vger.kernel.org
    Signed-off-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    07af7810
omap3-gta04.dtsi 22.7 KB