• Ian Ray's avatar
    gpio: pca953x: fix pca953x_irq_bus_sync_unlock race · bfc6444b
    Ian Ray authored
    Ensure that `i2c_lock' is held when setting interrupt latch and mask in
    pca953x_irq_bus_sync_unlock() in order to avoid races.
    
    The other (non-probe) call site pca953x_gpio_set_multiple() ensures the
    lock is held before calling pca953x_write_regs().
    
    The problem occurred when a request raced against irq_bus_sync_unlock()
    approximately once per thousand reboots on an i.MX8MP based system.
    
     * Normal case
    
       0-0022: write register AI|3a {03,02,00,00,01} Input latch P0
       0-0022: write register AI|49 {fc,fd,ff,ff,fe} Interrupt mask P0
       0-0022: write register AI|08 {ff,00,00,00,00} Output P3
       0-0022: write register AI|12 {fc,00,00,00,00} Config P3
    
     * Race case
    
       0-0022: write register AI|08 {ff,00,00,00,00} Output P3
       0-0022: write register AI|08 {03,02,00,00,01} *** Wrong register ***
       0-0022: write register AI|12 {fc,00,00,00,00} Config P3
       0-0022: write register AI|49 {fc,fd,ff,ff,fe} Interrupt mask P0
    Signed-off-by: default avatarIan Ray <ian.ray@gehealthcare.com>
    Link: https://lore.kernel.org/r/20240620042915.2173-1-ian.ray@gehealthcare.comSigned-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
    bfc6444b
gpio-pca953x.c 37.2 KB