• Zhihao Cheng's avatar
    ubifs: dbg_check_idx_size: Fix kmemleak if loading znode failed · 31a9d5f3
    Zhihao Cheng authored
    If function dbg_check_idx_size() failed by loading znode in mounting
    process, there are two problems:
      1. Allocated znodes won't be freed, which causes kmemleak in kernel:
         ubifs_mount
          dbg_check_idx_size
           dbg_walk_index
            c->zroot.znode = ubifs_load_znode
    	child = ubifs_load_znode // failed
    	// Loaded znodes won't be freed in error handling path.
      2. Global variable ubifs_clean_zn_cnt is not decreased, because
         ubifs_tnc_close() is not invoked in error handling path, which
         triggers a warning in ubifs_exit():
          WARNING: CPU: 1 PID: 1576 at fs/ubifs/super.c:2486 ubifs_exit
          Modules linked in: zstd ubifs(-) ubi nandsim
          CPU: 1 PID: 1576 Comm: rmmod Not tainted 6.7.0-rc6
          Call Trace:
    	ubifs_exit+0xca/0xc70 [ubifs]
    	__do_sys_delete_module+0x29a/0x4a0
    	do_syscall_64+0x6f/0x140
    
    Fix it by adding error handling path in dbg_check_idx_size() to release
    tnc tree.
    
    Fixes: 1e51764a ("UBIFS: add new flash file system")
    Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
    Suggested-by: default avatarRichard Weinberger <richard@nod.at>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    31a9d5f3
tnc_misc.c 13.2 KB