• Arnd Bergmann's avatar
    media: staging: atomisp: imx: remove dead code · 4a3039e2
    Arnd Bergmann authored
    Making some functions 'static' has uncovered a few functions that
    have no caller, through the gcc warnings:
    
    atomisp/i2c/imx/imx.c:1111:12: error: 'imx_t_focus_vcm' defined but not used [-Werror=unused-function]
    atomisp/i2c/imx/imx.c:1103:12: error: 'imx_vcm_init' defined but not used [-Werror=unused-function]
    atomisp/i2c/imx/imx.c:1095:12: error: 'imx_vcm_power_down' defined but not used [-Werror=unused-function]
    atomisp/i2c/imx/imx.c:1087:12: error: 'imx_vcm_power_up' defined but not used [-Werror=unused-function]
    
    All four of these can be removed. Since they call indirect functions,
    I also looked at how those are used in turn:
    
    - The power_up/power_down callbacks are called from other functions
      and are still needed.
    
    - The t_focus_vcm callbacks pointers are completely unused and can
      be removed in both imx and ov8858. Some of the handlers are called
      directly and can now be marked static, the others are dummy
      implemntations that we can remove.
    
    - vcm_init is unused in imx, but dw9718_vcm_init is used in ov8858,
      but is not used in imx, so that one needs to stay around. The callback
      pointers in imx can be removed.
    
    Fixes: 9a5a6911 ("staging: imx: fix non-static declarations")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    4a3039e2
drv201.c 4.44 KB